| Message ID | 20221111120156.48040-3-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | MSM8956/76 and Sony Xperia X / X Compact support | expand |
On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote: > Move qcom,msm8974-qfprom after qcom,msm8916-qfprom to respect > alphabetical ordering. > > Fixes: c8b336bb1aeb ("dt-bindings: nvmem: Add soc qfprom compatible strings") It's a style, code readability, but not a bug. I propose to drop the tag. With that: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Il 15/11/22 17:42, Krzysztof Kozlowski ha scritto: > On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote: >> Move qcom,msm8974-qfprom after qcom,msm8916-qfprom to respect >> alphabetical ordering. >> >> Fixes: c8b336bb1aeb ("dt-bindings: nvmem: Add soc qfprom compatible strings") > > It's a style, code readability, but not a bug. I propose to drop the tag. > > With that: > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Should I send a v3, or is it possible to drop the tag while applying it? Thanks, Angelo
On 16/11/2022 08:50, AngeloGioacchino Del Regno wrote: > Il 15/11/22 17:42, Krzysztof Kozlowski ha scritto: >> On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote: >>> Move qcom,msm8974-qfprom after qcom,msm8916-qfprom to respect >>> alphabetical ordering. >>> >>> Fixes: c8b336bb1aeb ("dt-bindings: nvmem: Add soc qfprom compatible >>> strings") >> >> It's a style, code readability, but not a bug. I propose to drop the tag. >> >> With that: >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> > > Should I send a v3, or is it possible to drop the tag while applying it? Applied after dropping fixes tag.. --srini > > Thanks, > Angelo >
Il 03/01/23 12:58, Srinivas Kandagatla ha scritto: > > > On 16/11/2022 08:50, AngeloGioacchino Del Regno wrote: >> Il 15/11/22 17:42, Krzysztof Kozlowski ha scritto: >>> On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote: >>>> Move qcom,msm8974-qfprom after qcom,msm8916-qfprom to respect >>>> alphabetical ordering. >>>> >>>> Fixes: c8b336bb1aeb ("dt-bindings: nvmem: Add soc qfprom compatible strings") >>> >>> It's a style, code readability, but not a bug. I propose to drop the tag. >>> >>> With that: >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> >> >> Should I send a v3, or is it possible to drop the tag while applying it? > > Applied after dropping fixes tag.. > Thanks for that! Cheers, Angelo
diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml index 2eab2f46cb65..474abdbb1ee7 100644 --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml @@ -19,8 +19,8 @@ properties: - qcom,apq8064-qfprom - qcom,apq8084-qfprom - qcom,ipq8064-qfprom - - qcom,msm8974-qfprom - qcom,msm8916-qfprom + - qcom,msm8974-qfprom - qcom,msm8996-qfprom - qcom,msm8998-qfprom - qcom,qcs404-qfprom
Move qcom,msm8974-qfprom after qcom,msm8916-qfprom to respect alphabetical ordering. Fixes: c8b336bb1aeb ("dt-bindings: nvmem: Add soc qfprom compatible strings") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)