| Message ID | 20230124183257.1525376-1-amit.pundir@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: Add reserved memory region | expand |
Hi Amit Pundir, I have a Poco F1 (EBBG) variant and I can confirm that the framebuffer address is same for the EBBG variant too. I did a quick check by running the following command based on this link[1]: xiber:~$ strings /dev/disk/by-partlabel/xbl_a | grep "Display Reserved" 0x9D400000, 0x02400000, "Display Reserved", AddMem, MEM_RES, SYS_MEM_CAP, Reserv, WRITE_BACK_XN So I think it's safe to move this to sdm845-xiaomi-beryllium-common.dtsi Regards, Joel Selvaraj [1] https://wiki.postmarketos.org/wiki/SDM845_Mainlining#Find_the_framebuffer_address On 24/01/23 12:32, Amit Pundir wrote: > Put cont splash memory region under the reserved-memory as > confirmed by the downstream code for Tianma variant as well. > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > --- > This change should probably go in sdm845-xiaomi-beryllium-common but > I don't have EBBG variant's downstream code nor the device to test. > > .../boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts > index 8e176111e599..47cbf725b0e3 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts > @@ -7,6 +7,14 @@ > / { > model = "Xiaomi Pocophone F1 (Tianma)"; > compatible = "xiaomi,beryllium", "qcom,sdm845"; > + > + reserved-memory { > + /* Cont splash region set up by the bootloader */ > + cont_splash_mem: framebuffer@9d400000 { > + reg = <0x0 0x9d400000 0x0 0x2400000>; > + no-map; > + }; > + }; > }; > > &display_panel {
On Thu, 26 Jan 2023 at 11:45, Joel Selvaraj <joelselvaraj.oss@gmail.com> wrote: > > Hi Amit Pundir, > > I have a Poco F1 (EBBG) variant and I can confirm that the framebuffer > address is same for the EBBG variant too. > > I did a quick check by running the following command based on this link[1]: > > xiber:~$ strings /dev/disk/by-partlabel/xbl_a | grep "Display Reserved" > > 0x9D400000, 0x02400000, "Display Reserved", AddMem, MEM_RES, > SYS_MEM_CAP, Reserv, WRITE_BACK_XN > > So I think it's safe to move this to sdm845-xiaomi-beryllium-common.dtsi ACK. Sending v2 shortly. > > Regards, > Joel Selvaraj > > [1] > https://wiki.postmarketos.org/wiki/SDM845_Mainlining#Find_the_framebuffer_address > > > > > On 24/01/23 12:32, Amit Pundir wrote: > > Put cont splash memory region under the reserved-memory as > > confirmed by the downstream code for Tianma variant as well. > > > > Signed-off-by: Amit Pundir <amit.pundir@linaro.org> > > --- > > This change should probably go in sdm845-xiaomi-beryllium-common but > > I don't have EBBG variant's downstream code nor the device to test. > > > > .../boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts > > index 8e176111e599..47cbf725b0e3 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts > > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts > > @@ -7,6 +7,14 @@ > > / { > > model = "Xiaomi Pocophone F1 (Tianma)"; > > compatible = "xiaomi,beryllium", "qcom,sdm845"; > > + > > + reserved-memory { > > + /* Cont splash region set up by the bootloader */ > > + cont_splash_mem: framebuffer@9d400000 { > > + reg = <0x0 0x9d400000 0x0 0x2400000>; > > + no-map; > > + }; > > + }; > > }; > > > > &display_panel {
diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts index 8e176111e599..47cbf725b0e3 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts @@ -7,6 +7,14 @@ / { model = "Xiaomi Pocophone F1 (Tianma)"; compatible = "xiaomi,beryllium", "qcom,sdm845"; + + reserved-memory { + /* Cont splash region set up by the bootloader */ + cont_splash_mem: framebuffer@9d400000 { + reg = <0x0 0x9d400000 0x0 0x2400000>; + no-map; + }; + }; }; &display_panel {
Put cont splash memory region under the reserved-memory as confirmed by the downstream code for Tianma variant as well. Signed-off-by: Amit Pundir <amit.pundir@linaro.org> --- This change should probably go in sdm845-xiaomi-beryllium-common but I don't have EBBG variant's downstream code nor the device to test. .../boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 8 ++++++++ 1 file changed, 8 insertions(+)