diff mbox series

[1/1] arm64: defconfig: Enable qcom msm8994 clk drivers

Message ID 20230130111014.27980-1-pvorel@suse.cz (mailing list archive)
State Changes Requested
Headers show
Series [1/1] arm64: defconfig: Enable qcom msm8994 clk drivers | expand

Commit Message

Petr Vorel Jan. 30, 2023, 11:10 a.m. UTC
Enabling the clk drivers on msm8994 allows to boot and test most device
drivers on this SoC.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
NOTE: Working as part of SUSE hackweek, that's why I use my work mail
instead of usual private gmail.

Kind regards,
Petr

 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjorn Andersson Jan. 30, 2023, 3:27 p.m. UTC | #1
On Mon, Jan 30, 2023 at 12:10:14PM +0100, Petr Vorel wrote:
> Enabling the clk drivers on msm8994 allows to boot and test most device
> drivers on this SoC.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Now that we can handle probe defer on the power-domains, can this be
made =m instead?

Regards,
Bjorn

> ---
> NOTE: Working as part of SUSE hackweek, that's why I use my work mail
> instead of usual private gmail.
> 
> Kind regards,
> Petr
> 
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index bfafb4313436..c6b08a9d8944 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1105,6 +1105,7 @@ CONFIG_IPQ_GCC_6018=y
>  CONFIG_IPQ_GCC_8074=y
>  CONFIG_MSM_GCC_8916=y
>  CONFIG_MSM_GCC_8994=y
> +CONFIG_MSM_MMCC_8994=y
>  CONFIG_MSM_MMCC_8996=y
>  CONFIG_MSM_GCC_8998=y
>  CONFIG_QCS_GCC_404=y
> -- 
> 2.39.1
>
Petr Vorel Jan. 30, 2023, 6:20 p.m. UTC | #2
Hi Bjorn,

> On Mon, Jan 30, 2023 at 12:10:14PM +0100, Petr Vorel wrote:
> > Enabling the clk drivers on msm8994 allows to boot and test most device
> > drivers on this SoC.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> Now that we can handle probe defer on the power-domains, can this be
> made =m instead?
Thanks for your tip. Sure, if it's safe to change the rest of CONFIG_MSM_MMCC_.*
to module as well (in separate patch). I'll send v2.

Kind regards,
Petr

> Regards,
> Bjorn

> > ---
> > NOTE: Working as part of SUSE hackweek, that's why I use my work mail
> > instead of usual private gmail.

> > Kind regards,
> > Petr

> >  arch/arm64/configs/defconfig | 1 +
> >  1 file changed, 1 insertion(+)

> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index bfafb4313436..c6b08a9d8944 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1105,6 +1105,7 @@ CONFIG_IPQ_GCC_6018=y
> >  CONFIG_IPQ_GCC_8074=y
> >  CONFIG_MSM_GCC_8916=y
> >  CONFIG_MSM_GCC_8994=y
> > +CONFIG_MSM_MMCC_8994=y
> >  CONFIG_MSM_MMCC_8996=y
> >  CONFIG_MSM_GCC_8998=y
> >  CONFIG_QCS_GCC_404=y
> > -- 
> > 2.39.1
Petr Vorel Jan. 30, 2023, 7:12 p.m. UTC | #3
> On Mon, Jan 30, 2023 at 12:10:14PM +0100, Petr Vorel wrote:
> > Enabling the clk drivers on msm8994 allows to boot and test most device
> > drivers on this SoC.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> Now that we can handle probe defer on the power-domains, can this be
> made =m instead?

Out of curiosity may I know what commit implemented handling probe defer on
power-domains?

Kind regards,
Petr

> Regards,
> Bjorn

> > ---
> > NOTE: Working as part of SUSE hackweek, that's why I use my work mail
> > instead of usual private gmail.

> > Kind regards,
> > Petr

> >  arch/arm64/configs/defconfig | 1 +
> >  1 file changed, 1 insertion(+)

> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index bfafb4313436..c6b08a9d8944 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1105,6 +1105,7 @@ CONFIG_IPQ_GCC_6018=y
> >  CONFIG_IPQ_GCC_8074=y
> >  CONFIG_MSM_GCC_8916=y
> >  CONFIG_MSM_GCC_8994=y
> > +CONFIG_MSM_MMCC_8994=y
> >  CONFIG_MSM_MMCC_8996=y
> >  CONFIG_MSM_GCC_8998=y
> >  CONFIG_QCS_GCC_404=y
> > -- 
> > 2.39.1
Bjorn Andersson Feb. 8, 2023, 11:06 p.m. UTC | #4
On Mon, Jan 30, 2023 at 08:12:49PM +0100, Petr Vorel wrote:
> > On Mon, Jan 30, 2023 at 12:10:14PM +0100, Petr Vorel wrote:
> > > Enabling the clk drivers on msm8994 allows to boot and test most device
> > > drivers on this SoC.
> 
> > > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> 
> > Now that we can handle probe defer on the power-domains, can this be
> > made =m instead?
> 
> Out of curiosity may I know what commit implemented handling probe defer on
> power-domains?
> 

Probe defer support has been there for a long time, but it was not
reliable after late_initcall.

I believe 2b28a1a84a0e ("driver core: Extend deferred probe timeout on
driver registration") is the change that altered the behavior, so we can
now use it for kernel modules as well.

Regards,
Bjorn

> Kind regards,
> Petr
> 
> > Regards,
> > Bjorn
> 
> > > ---
> > > NOTE: Working as part of SUSE hackweek, that's why I use my work mail
> > > instead of usual private gmail.
> 
> > > Kind regards,
> > > Petr
> 
> > >  arch/arm64/configs/defconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> 
> > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > index bfafb4313436..c6b08a9d8944 100644
> > > --- a/arch/arm64/configs/defconfig
> > > +++ b/arch/arm64/configs/defconfig
> > > @@ -1105,6 +1105,7 @@ CONFIG_IPQ_GCC_6018=y
> > >  CONFIG_IPQ_GCC_8074=y
> > >  CONFIG_MSM_GCC_8916=y
> > >  CONFIG_MSM_GCC_8994=y
> > > +CONFIG_MSM_MMCC_8994=y
> > >  CONFIG_MSM_MMCC_8996=y
> > >  CONFIG_MSM_GCC_8998=y
> > >  CONFIG_QCS_GCC_404=y
> > > -- 
> > > 2.39.1
>
Petr Vorel Feb. 9, 2023, 8 a.m. UTC | #5
> On Mon, Jan 30, 2023 at 08:12:49PM +0100, Petr Vorel wrote:
> > > On Mon, Jan 30, 2023 at 12:10:14PM +0100, Petr Vorel wrote:
> > > > Enabling the clk drivers on msm8994 allows to boot and test most device
> > > > drivers on this SoC.

> > > > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> > > Now that we can handle probe defer on the power-domains, can this be
> > > made =m instead?

> > Out of curiosity may I know what commit implemented handling probe defer on
> > power-domains?


> Probe defer support has been there for a long time, but it was not
> reliable after late_initcall.

> I believe 2b28a1a84a0e ("driver core: Extend deferred probe timeout on
> driver registration") is the change that altered the behavior, so we can
> now use it for kernel modules as well.

Thanks for info! I have v2 prepared, but I'd prefer to test it, thus I'll send
it next week after I get time to test it.

Kind regards,
Petr

> Regards,
> Bjorn
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index bfafb4313436..c6b08a9d8944 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1105,6 +1105,7 @@  CONFIG_IPQ_GCC_6018=y
 CONFIG_IPQ_GCC_8074=y
 CONFIG_MSM_GCC_8916=y
 CONFIG_MSM_GCC_8994=y
+CONFIG_MSM_MMCC_8994=y
 CONFIG_MSM_MMCC_8996=y
 CONFIG_MSM_GCC_8998=y
 CONFIG_QCS_GCC_404=y