| Message ID | 20230307232340.2370476-1-bmasney@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b891251b40d4dc4cfd28341f62f6784c02ad3a78 |
| Headers | show |
| Series | arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware | expand |
On 08/03/2023 00:23, Brian Masney wrote: > The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually > named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and > correct the name to match what's in Qualcomm's deliverable. I don't think vendor deliverables matter. linux-firmware is here more important. The file will be cdsp.mbn in the firmware, won't it? Best regards, Krzysztof
On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote: > On 08/03/2023 00:23, Brian Masney wrote: > > The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually > > named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and > > correct the name to match what's in Qualcomm's deliverable. > > I don't think vendor deliverables matter. linux-firmware is here more > important. The file will be cdsp.mbn in the firmware, won't it? cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I far as I know there's no plan for someone to submit those since QC would need to approve that. I can ask though since the DTS for these two bits has been submitted upstream. Brian
On 08/03/2023 13:06, Brian Masney wrote: > On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote: >> On 08/03/2023 00:23, Brian Masney wrote: >>> The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually >>> named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and >>> correct the name to match what's in Qualcomm's deliverable. >> >> I don't think vendor deliverables matter. linux-firmware is here more >> important. The file will be cdsp.mbn in the firmware, won't it? > > cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I > far as I know there's no plan for someone to submit those since QC would > need to approve that. I can ask though since the DTS for these two bits > has been submitted upstream. If they are never going to be submitted, vendor is allowed to rename them all the time in their "deliverables". Are you going to rename the file every time Qualcomm decides to rename them? There is no single guarantee the names would be fixed, because vendor is allowed to do absolutely anything. Sorry, but any argument in upstream DTS that "someone downstream does something" is deemed to fail in many cases. Best regards, Krzysztof
On Wed, Mar 08, 2023 at 01:36:52PM +0100, Krzysztof Kozlowski wrote: > On 08/03/2023 13:06, Brian Masney wrote: > > On Wed, Mar 08, 2023 at 12:02:04PM +0100, Krzysztof Kozlowski wrote: > >> On 08/03/2023 00:23, Brian Masney wrote: > >>> The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually > >>> named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and > >>> correct the name to match what's in Qualcomm's deliverable. > >> > >> I don't think vendor deliverables matter. linux-firmware is here more > >> important. The file will be cdsp.mbn in the firmware, won't it? > > > > cdsp0.mbn and cdsp1.mbn for the sa8540p are not in linux-firmware and I > > far as I know there's no plan for someone to submit those since QC would > > need to approve that. I can ask though since the DTS for these two bits > > has been submitted upstream. > > If they are never going to be submitted, vendor is allowed to rename > them all the time in their "deliverables". Are you going to rename the > file every time Qualcomm decides to rename them? There is no single > guarantee the names would be fixed, because vendor is allowed to do > absolutely anything. > cdsp0.mbn and cdsp1.mbn are better names, so let's use this patch to define that if/when they are pushed to linux-firmware it should follow this scheme. > Sorry, but any argument in upstream DTS that "someone downstream does > something" is deemed to fail in many cases. > That is indeed an insufficient argument, in many cases. Regards, Bjorn
On Tue, 7 Mar 2023 18:23:40 -0500, Brian Masney wrote: > The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually > named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and > correct the name to match what's in Qualcomm's deliverable. > > Applied, thanks! [1/1] arm64: dts: qcom: sa8540p-ride: correct name of remoteproc_nsp0 firmware commit: b891251b40d4dc4cfd28341f62f6784c02ad3a78 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts index 6c547f1b13dc..0f560a4661eb 100644 --- a/arch/arm64/boot/dts/qcom/sa8540p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8540p-ride.dts @@ -177,7 +177,7 @@ &qup2_uart17 { }; &remoteproc_nsp0 { - firmware-name = "qcom/sa8540p/cdsp.mbn"; + firmware-name = "qcom/sa8540p/cdsp0.mbn"; status = "okay"; };
The cdsp.mbn firmware that's referenced in sa8540p-ride.dts is actually named cdsp0.mbn in the deliverables from Qualcomm. Let's go ahead and correct the name to match what's in Qualcomm's deliverable. Signed-off-by: Brian Masney <bmasney@redhat.com> --- arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)