| Message ID | 20230314041515.15883-2-quic_kathirav@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | rework mailbox compatibles for Qualcomm IPQ SoCs | expand |
On 14/03/2023 05:15, Kathiravan T wrote: > Since the IPQ8074 mailbox is compatible with the IPQ6018, lets create > the fallback to ipq6018 compatible, so that we don't bloat the of_device_id > table in the driver. > > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> > --- Why do you send conflicting patches and take out some pieces of my patchset into yours? This was send already 1.5 months ago: https://lore.kernel.org/all/20230202161856.385825-1-krzysztof.kozlowski@linaro.org/ NAK. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index d888ead09282..00f0ed354a6a 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -19,11 +19,10 @@ properties: - items: - enum: - qcom,ipq5332-apcs-apps-global + - qcom,ipq8074-apcs-apps-global - const: qcom,ipq6018-apcs-apps-global - items: - enum: - - qcom,ipq6018-apcs-apps-global - - qcom,ipq8074-apcs-apps-global - qcom,msm8996-apcs-hmss-global - qcom,msm8998-apcs-hmss-global - qcom,qcm2290-apcs-hmss-global @@ -111,7 +110,6 @@ allOf: contains: enum: - qcom,ipq6018-apcs-apps-global - - qcom,ipq8074-apcs-apps-global then: properties: clocks: @@ -152,7 +150,6 @@ allOf: contains: enum: - qcom,ipq6018-apcs-apps-global - - qcom,ipq8074-apcs-apps-global then: properties: '#clock-cells':
Since the IPQ8074 mailbox is compatible with the IPQ6018, lets create the fallback to ipq6018 compatible, so that we don't bloat the of_device_id table in the driver. Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)