| Message ID | 20230404185329.1925964-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static | expand |
On 04/04/2023 21:53, Tom Rix wrote: > smatch reports > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol > 'msm8x76_config' was not declared. Should it be static? > > This variable is only used in one file so should be static. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Tue, 04 Apr 2023 14:53:29 -0400, Tom Rix wrote: > smatch reports > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol > 'msm8x76_config' was not declared. Should it be static? > > This variable is only used in one file so should be static. > > > [...] Applied, thanks! [1/1] drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static https://gitlab.freedesktop.org/lumag/msm/-/commit/d2f762745162 Best regards,
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c index 1f1555aa02d2..2eec2d78f32a 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c @@ -655,7 +655,7 @@ static const struct mdp5_cfg_hw msm8x96_config = { .max_clk = 412500000, }; -const struct mdp5_cfg_hw msm8x76_config = { +static const struct mdp5_cfg_hw msm8x76_config = { .name = "msm8x76", .mdp = { .count = 1,
smatch reports drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol 'msm8x76_config' was not declared. Should it be static? This variable is only used in one file so should be static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)