| Message ID | 20230521-drm-panels-sony-v1-1-541c341d6bee@somainline.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/panel: Drivers for four Sony CMD-mode (and DSC) panels | expand |
On 21/05/2023 23:23, Marijn Suijten wrote: > As per the config name this Display IC features a DSI command-mode > interface (or the command to switch to video mode is not > known/documented) and does not use any of the video-mode helper > utilities, hence should not select VIDEOMODE_HELPERS. In addition it > uses devm_gpiod_get() and related functions from GPIOLIB. > > Fixes: 5933baa36e26 ("drm/panel/samsung-sofef00: Add panel for OnePlus 6/T devices") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > --- > drivers/gpu/drm/panel/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 2b9d6db7860ba..67ef898d133f2 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -608,10 +608,10 @@ config DRM_PANEL_SAMSUNG_S6E8AA0 > > config DRM_PANEL_SAMSUNG_SOFEF00 > tristate "Samsung sofef00/s6e3fc2x01 OnePlus 6/6T DSI cmd mode panels" > + depends on GPIOLIB > depends on OF > depends on DRM_MIPI_DSI > depends on BACKLIGHT_CLASS_DEVICE > - select VIDEOMODE_HELPERS > help > Say Y or M here if you want to enable support for the Samsung AMOLED > command mode panels found in the OnePlus 6/6T smartphones. > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
On 21/05/2023 22:23, Marijn Suijten wrote: > As per the config name this Display IC features a DSI command-mode > interface (or the command to switch to video mode is not > known/documented) and does not use any of the video-mode helper > utilities, hence should not select VIDEOMODE_HELPERS. In addition it > uses devm_gpiod_get() and related functions from GPIOLIB. > > Fixes: 5933baa36e26 ("drm/panel/samsung-sofef00: Add panel for OnePlus 6/T devices") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> Reviewed-by: Caleb Connolly <caleb@connolly.tech> > --- > drivers/gpu/drm/panel/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > index 2b9d6db7860ba..67ef898d133f2 100644 > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -608,10 +608,10 @@ config DRM_PANEL_SAMSUNG_S6E8AA0 > > config DRM_PANEL_SAMSUNG_SOFEF00 > tristate "Samsung sofef00/s6e3fc2x01 OnePlus 6/6T DSI cmd mode panels" > + depends on GPIOLIB > depends on OF > depends on DRM_MIPI_DSI > depends on BACKLIGHT_CLASS_DEVICE > - select VIDEOMODE_HELPERS > help > Say Y or M here if you want to enable support for the Samsung AMOLED > command mode panels found in the OnePlus 6/6T smartphones. > > -- > 2.40.1 >
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 2b9d6db7860ba..67ef898d133f2 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -608,10 +608,10 @@ config DRM_PANEL_SAMSUNG_S6E8AA0 config DRM_PANEL_SAMSUNG_SOFEF00 tristate "Samsung sofef00/s6e3fc2x01 OnePlus 6/6T DSI cmd mode panels" + depends on GPIOLIB depends on OF depends on DRM_MIPI_DSI depends on BACKLIGHT_CLASS_DEVICE - select VIDEOMODE_HELPERS help Say Y or M here if you want to enable support for the Samsung AMOLED command mode panels found in the OnePlus 6/6T smartphones.
As per the config name this Display IC features a DSI command-mode interface (or the command to switch to video mode is not known/documented) and does not use any of the video-mode helper utilities, hence should not select VIDEOMODE_HELPERS. In addition it uses devm_gpiod_get() and related functions from GPIOLIB. Fixes: 5933baa36e26 ("drm/panel/samsung-sofef00: Add panel for OnePlus 6/T devices") Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> --- drivers/gpu/drm/panel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)