| Message ID | 20230522191701.13406-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm: Use struct fb_info.screen_buffer | expand |
Hello Thomas, On Mon, May 22, 2023 at 9:17 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > The fbdev framebuffer is in system memory. Store the address in > the field 'screen_buffer'. Fixes the following sparse warning. > > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces) > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: expected char [noderef] __iomem *screen_base > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: got void * > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On 22/05/2023 22:17, Thomas Zimmermann wrote: > The fbdev framebuffer is in system memory. Store the address in > the field 'screen_buffer'. Fixes the following sparse warning. > > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces) > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: expected char [noderef] __iomem *screen_base > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: got void * > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Mon, 22 May 2023 21:17:01 +0200, Thomas Zimmermann wrote: > The fbdev framebuffer is in system memory. Store the address in > the field 'screen_buffer'. Fixes the following sparse warning. > > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces) > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: expected char [noderef] __iomem *screen_base > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: got void * > > [...] Applied, thanks! [1/1] drm/msm: Use struct fb_info.screen_buffer https://gitlab.freedesktop.org/lumag/msm/-/commit/4fb5ad612c5c Best regards,
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index 2ebc86381e1c..ce0ba6d1979a 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm/msm_fbdev.c @@ -121,9 +121,9 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, drm_fb_helper_fill_info(fbi, helper, sizes); - fbi->screen_base = msm_gem_get_vaddr(bo); - if (IS_ERR(fbi->screen_base)) { - ret = PTR_ERR(fbi->screen_base); + fbi->screen_buffer = msm_gem_get_vaddr(bo); + if (IS_ERR(fbi->screen_buffer)) { + ret = PTR_ERR(fbi->screen_buffer); goto fail; } fbi->screen_size = bo->size;
The fbdev framebuffer is in system memory. Store the address in the field 'screen_buffer'. Fixes the following sparse warning. ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces) ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: expected char [noderef] __iomem *screen_base ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: got void * Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/msm/msm_fbdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)