| Message ID | 20230531-rpm-rproc-v3-5-a07dcdefd918@gerhold.net (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add dedicated device tree node for RPM processor/subsystem | expand |
On 15/06/2023 18:50, Stephan Gerhold wrote: > Semantically glink-edge and glink-rpm-edge are similar: Both describe > the communication channels to a remote processor. The RPM glink-edge is > a special case that needs slightly different properties but otherwise > it is used exactly the same. > > To improve consistency use the same "glink-edge" node name also for > glink-rpm-edge. Drop the $nodename from qcom,glink-edge.yaml to avoid > matching the wrong schema. qcom,glink-edge.yaml is always referenced > explicitly from other schemas. This will already ensure that the nodes > are being checked, so it's not necessary to bind to all nodes named > "glink-edge". > > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml index 7b43ad3daa56..e78a89c9ec41 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml @@ -14,9 +14,6 @@ description: related to the remote processor. properties: - $nodename: - const: glink-edge - apr: $ref: /schemas/soc/qcom/qcom,apr.yaml# required: diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml index f5a044e20c4e..884158bccd50 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml +++ b/Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml @@ -84,7 +84,7 @@ examples: - | #include <dt-bindings/interrupt-controller/arm-gic.h> - rpm-glink { + glink-edge { compatible = "qcom,glink-rpm"; interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>; mboxes = <&apcs_glb 0>;
Semantically glink-edge and glink-rpm-edge are similar: Both describe the communication channels to a remote processor. The RPM glink-edge is a special case that needs slightly different properties but otherwise it is used exactly the same. To improve consistency use the same "glink-edge" node name also for glink-rpm-edge. Drop the $nodename from qcom,glink-edge.yaml to avoid matching the wrong schema. qcom,glink-edge.yaml is always referenced explicitly from other schemas. This will already ensure that the nodes are being checked, so it's not necessary to bind to all nodes named "glink-edge". Signed-off-by: Stephan Gerhold <stephan@gerhold.net> --- Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml | 3 --- Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-)