diff mbox series

[V1] scsi: ufs: ufs-qcom: Update UFS devfreq Parameters

Message ID 20230711104006.15872-1-quic_nitirawa@quicinc.com (mailing list archive)
State Superseded
Headers show
Series [V1] scsi: ufs: ufs-qcom: Update UFS devfreq Parameters | expand

Commit Message

Nitin Rawat July 11, 2023, 10:40 a.m. UTC 
To support the periodic polling mode without stop
caused by CPU idle state, enable delayed timer
as default instead of deferrable timer for
qualcomm platforms.
And change UFS devfreq downdifferential threshold to 65
for less aggresive downscaling.

Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
---
 drivers/ufs/host/ufs-qcom.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--
2.17.1

Comments

Konrad Dybcio July 15, 2023, 2:09 p.m. UTC | #1 
On 11.07.2023 12:40, Nitin Rawat wrote:
> To support the periodic polling mode without stop
> caused by CPU idle state, enable delayed timer
> as default instead of deferrable timer for
> qualcomm platforms.
> And change UFS devfreq downdifferential threshold to 65
> for less aggresive downscaling.
Please wrap your commit messages at around 70 characters, 50
makes it very hard to read.

Konrad
> 
> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
> ---
>  drivers/ufs/host/ufs-qcom.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 82d02e7f3b4f..a15815c951ca 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1388,8 +1388,9 @@ static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,
>  					struct devfreq_simple_ondemand_data *d)
>  {
>  	p->polling_ms = 60;
> +	p->timer = DEVFREQ_TIMER_DELAYED;
>  	d->upthreshold = 70;
> -	d->downdifferential = 5;
> +	d->downdifferential = 65;
>  }
>  #else
>  static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,
> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 82d02e7f3b4f..a15815c951ca 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -1388,8 +1388,9 @@  static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,
 					struct devfreq_simple_ondemand_data *d)
 {
 	p->polling_ms = 60;
+	p->timer = DEVFREQ_TIMER_DELAYED;
 	d->upthreshold = 70;
-	d->downdifferential = 5;
+	d->downdifferential = 65;
 }
 #else
 static void ufs_qcom_config_scaling_param(struct ufs_hba *hba,