| Message ID | 20230727212208.102501-13-robdclark@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm/adreno: Move away from legacy revision matching | expand |
On 27/07/2023 23:20, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > Upcoming GPUs use an opaque chip-id for identifying the GPU. Examples? Anyway, I think we should insist here of using something human-readable, even if Qualcomm/Adreno internally use some weird numbers. > > Signed-off-by: Rob Clark <robdclark@chromium.org> > --- > Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml > index 58ca8912a8c3..56b9b247e8c2 100644 > --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml > +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml > @@ -13,6 +13,12 @@ maintainers: > properties: > compatible: > oneOf: > + - description: | > + The driver is parsing the compat string for Adreno to > + figure out the chip-id. > + items: > + - pattern: '^qcom,adreno-[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]$' {8} should work? Best regards, Krzysztof
On Fri, Jul 28, 2023 at 12:27 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 27/07/2023 23:20, Rob Clark wrote: > > From: Rob Clark <robdclark@chromium.org> > > > > Upcoming GPUs use an opaque chip-id for identifying the GPU. > > Examples? We'll know when we bring up the hw. But the main point is that we shouldn't expect, for example, the high 8 bits to tell us the generation, any more than we could if it was a pci id. We may not end up needing to use this new binding much, I _think_ we should be able to read it from the fw in most cases, at least for android devices. I'm unsure at this point about windows/chromebooks. > Anyway, I think we should insist here of using something human-readable, > even if Qualcomm/Adreno internally use some weird numbers. I mean qcom,sc8280cx-adreno is human readable but not really very informative. Encoding the chip-id is just a way to avoid the qcom,chipid field in the bindings, which qcom used downstream. The new pattern accomplishes the same thing as the existing one, but without trying to imply some meaning that becomes increasingly non-existent as qc moves to decouple the id from marketing names. > > > > Signed-off-by: Rob Clark <robdclark@chromium.org> > > --- > > Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml > > index 58ca8912a8c3..56b9b247e8c2 100644 > > --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml > > @@ -13,6 +13,12 @@ maintainers: > > properties: > > compatible: > > oneOf: > > + - description: | > > + The driver is parsing the compat string for Adreno to > > + figure out the chip-id. > > + items: > > + - pattern: '^qcom,adreno-[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]$' > > {8} should work? > so '^qcom,adreno-[0-9a-f]{8}$' BR, -R > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml b/Documentation/devicetree/bindings/display/msm/gpu.yaml index 58ca8912a8c3..56b9b247e8c2 100644 --- a/Documentation/devicetree/bindings/display/msm/gpu.yaml +++ b/Documentation/devicetree/bindings/display/msm/gpu.yaml @@ -13,6 +13,12 @@ maintainers: properties: compatible: oneOf: + - description: | + The driver is parsing the compat string for Adreno to + figure out the chip-id. + items: + - pattern: '^qcom,adreno-[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]$' + - const: qcom,adreno - description: | The driver is parsing the compat string for Adreno to figure out the gpu-id and patch level.