| Message ID | 20230817213815.638189-2-ahalaney@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1ff6569b0ffe7a2e311104cb3cd841983e484ac9 |
| Headers | show |
| Series | sa8775p-ride: Describe ethernet phy IRQs | expand |
On 17.08.2023 23:37, Andrew Halaney wrote: > There's an irq hooked up, so let's describe it. > > Prior to commit 9757300d2750 > ("pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets") > one would not see the IRQ fire, despite some (invasive) debugging > showing that the GPIO was in fact asserted, resulting in the interface > staying down. > > Now that the IRQ is properly routed we can describe it. > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Thu, Aug 17, 2023 at 11:38 PM Andrew Halaney <ahalaney@redhat.com> wrote: > > There's an irq hooked up, so let's describe it. > > Prior to commit 9757300d2750 > ("pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets") > one would not see the IRQ fire, despite some (invasive) debugging > showing that the GPIO was in fact asserted, resulting in the interface > staying down. > > Now that the IRQ is properly routed we can describe it. > > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > index 81a7eeb9cfcd..8fde6935cd6e 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > @@ -285,6 +285,7 @@ sgmii_phy0: phy@8 { > compatible = "ethernet-phy-id0141.0dd4"; > reg = <0x8>; > device_type = "ethernet-phy"; > + interrupts-extended = <&tlmm 7 IRQ_TYPE_EDGE_FALLING>; > reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>; > reset-assert-us = <11000>; > reset-deassert-us = <70000>; > -- > 2.41.0 > Nice! Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts index 81a7eeb9cfcd..8fde6935cd6e 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts @@ -285,6 +285,7 @@ sgmii_phy0: phy@8 { compatible = "ethernet-phy-id0141.0dd4"; reg = <0x8>; device_type = "ethernet-phy"; + interrupts-extended = <&tlmm 7 IRQ_TYPE_EDGE_FALLING>; reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>; reset-assert-us = <11000>; reset-deassert-us = <70000>;
There's an irq hooked up, so let's describe it. Prior to commit 9757300d2750 ("pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets") one would not see the IRQ fire, despite some (invasive) debugging showing that the GPIO was in fact asserted, resulting in the interface staying down. Now that the IRQ is properly routed we can describe it. Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 1 + 1 file changed, 1 insertion(+)