| Message ID | 20230825230109.2264345-1-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/msm/dp: Add newlines to debug printks | expand |
On Sat, 26 Aug 2023 at 02:01, Stephen Boyd <swboyd@chromium.org> wrote: > > These debug printks are missing newlines, causing drm debug logs to be > hard to read. Add newlines so that the messages are on their own line. > > Cc: Kuogee Hsieh <quic_khsieh@quicinc.com> > Cc: Vinod Polimera <quic_vpolimer@quicinc.com> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/gpu/drm/msm/dp/dp_link.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease of debugging") Fixes: cd779808cccd ("drm/msm/dp: Add basic PSR support for eDP") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c > index 42427129acea..6375daaeb98e 100644 > --- a/drivers/gpu/drm/msm/dp/dp_link.c > +++ b/drivers/gpu/drm/msm/dp/dp_link.c > @@ -1090,7 +1090,7 @@ int dp_link_process_request(struct dp_link *dp_link) > } else if (dp_link_read_psr_error_status(link)) { > DRM_ERROR("PSR IRQ_HPD received\n"); > } else if (dp_link_psr_capability_changed(link)) { > - drm_dbg_dp(link->drm_dev, "PSR Capability changed"); > + drm_dbg_dp(link->drm_dev, "PSR Capability changed\n"); > } else { > ret = dp_link_process_link_status_update(link); > if (!ret) { > @@ -1107,7 +1107,7 @@ int dp_link_process_request(struct dp_link *dp_link) > } > } > > - drm_dbg_dp(link->drm_dev, "sink request=%#x", > + drm_dbg_dp(link->drm_dev, "sink request=%#x\n", > dp_link->sink_request); > return ret; > } > > base-commit: 706a741595047797872e669b3101429ab8d378ef > -- > https://chromeos.dev >
On 8/25/2023 4:01 PM, Stephen Boyd wrote: > These debug printks are missing newlines, causing drm debug logs to be > hard to read. Add newlines so that the messages are on their own line. > > Cc: Kuogee Hsieh <quic_khsieh@quicinc.com> > Cc: Vinod Polimera <quic_vpolimer@quicinc.com> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/gpu/drm/msm/dp/dp_link.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c > index 42427129acea..6375daaeb98e 100644 > --- a/drivers/gpu/drm/msm/dp/dp_link.c > +++ b/drivers/gpu/drm/msm/dp/dp_link.c > @@ -1090,7 +1090,7 @@ int dp_link_process_request(struct dp_link *dp_link) > } else if (dp_link_read_psr_error_status(link)) { > DRM_ERROR("PSR IRQ_HPD received\n"); > } else if (dp_link_psr_capability_changed(link)) { > - drm_dbg_dp(link->drm_dev, "PSR Capability changed"); > + drm_dbg_dp(link->drm_dev, "PSR Capability changed\n"); > } else { > ret = dp_link_process_link_status_update(link); > if (!ret) { > @@ -1107,7 +1107,7 @@ int dp_link_process_request(struct dp_link *dp_link) > } > } > > - drm_dbg_dp(link->drm_dev, "sink request=%#x", > + drm_dbg_dp(link->drm_dev, "sink request=%#x\n", > dp_link->sink_request); perhaps we can move sink_request to the previous line itself with this patch and we can avoid the line break. But thats a very minor comment, otherwise LGTM Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > return ret; > } > > base-commit: 706a741595047797872e669b3101429ab8d378ef
diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c index 42427129acea..6375daaeb98e 100644 --- a/drivers/gpu/drm/msm/dp/dp_link.c +++ b/drivers/gpu/drm/msm/dp/dp_link.c @@ -1090,7 +1090,7 @@ int dp_link_process_request(struct dp_link *dp_link) } else if (dp_link_read_psr_error_status(link)) { DRM_ERROR("PSR IRQ_HPD received\n"); } else if (dp_link_psr_capability_changed(link)) { - drm_dbg_dp(link->drm_dev, "PSR Capability changed"); + drm_dbg_dp(link->drm_dev, "PSR Capability changed\n"); } else { ret = dp_link_process_link_status_update(link); if (!ret) { @@ -1107,7 +1107,7 @@ int dp_link_process_request(struct dp_link *dp_link) } } - drm_dbg_dp(link->drm_dev, "sink request=%#x", + drm_dbg_dp(link->drm_dev, "sink request=%#x\n", dp_link->sink_request); return ret; }
These debug printks are missing newlines, causing drm debug logs to be hard to read. Add newlines so that the messages are on their own line. Cc: Kuogee Hsieh <quic_khsieh@quicinc.com> Cc: Vinod Polimera <quic_vpolimer@quicinc.com> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- drivers/gpu/drm/msm/dp/dp_link.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 706a741595047797872e669b3101429ab8d378ef