| Message ID | 20230829-fix-sm_gpucc_8550-deps-v1-1-d751f6cd35b2@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 75d1d3a433f0a0748a89eb074830e9b635a19fd2 |
| Headers | show |
| Series | clk: qcom: Fix SM_GPUCC_8450 dependencies | expand |
On 29.08.2023 16:08, Nathan Chancellor wrote: > CONFIG_SM_GCC_8450 depends on ARM64 but it is selected by > CONFIG_SM_GPUCC_8450, which can be selected on ARM, resulting in a > Kconfig warning. > > WARNING: unmet direct dependencies detected for SM_GCC_8450 > Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n]) > Selected by [y]: > - SM_GPUCC_8450 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] > > Add the same dependencies to CONFIG_SM_GPUCC_8450 to resolve the > warning. > > Fixes: 728692d49edc ("clk: qcom: Add support for SM8450 GPUCC") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > I think this is more of a silent conflict between commit ab7f00379fe9 > ("clk: qcom: restrict drivers per ARM/ARM64") and commit 728692d49edc > ("clk: qcom: Add support for SM8450 GPUCC"), rather than just a fault of > 728692d49edc but ab7f00379fe9 was merged first so I just chose > 728692d49edc as the problematic commit for the message, feel free to > adjust it as necessary. Yep, looks like Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
Quoting Nathan Chancellor (2023-08-29 07:08:47) > CONFIG_SM_GCC_8450 depends on ARM64 but it is selected by > CONFIG_SM_GPUCC_8450, which can be selected on ARM, resulting in a > Kconfig warning. > > WARNING: unmet direct dependencies detected for SM_GCC_8450 > Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n]) > Selected by [y]: > - SM_GPUCC_8450 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] > > Add the same dependencies to CONFIG_SM_GPUCC_8450 to resolve the > warning. > > Fixes: 728692d49edc ("clk: qcom: Add support for SM8450 GPUCC") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- Applied to clk-next
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index bd9bfb11b328..865db5202e4c 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -986,6 +986,7 @@ config SM_GPUCC_8350 config SM_GPUCC_8450 tristate "SM8450 Graphics Clock Controller" + depends on ARM64 || COMPILE_TEST select SM_GCC_8450 help Support for the graphics clock controller on SM8450 devices.
CONFIG_SM_GCC_8450 depends on ARM64 but it is selected by CONFIG_SM_GPUCC_8450, which can be selected on ARM, resulting in a Kconfig warning. WARNING: unmet direct dependencies detected for SM_GCC_8450 Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n]) Selected by [y]: - SM_GPUCC_8450 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] Add the same dependencies to CONFIG_SM_GPUCC_8450 to resolve the warning. Fixes: 728692d49edc ("clk: qcom: Add support for SM8450 GPUCC") Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- I think this is more of a silent conflict between commit ab7f00379fe9 ("clk: qcom: restrict drivers per ARM/ARM64") and commit 728692d49edc ("clk: qcom: Add support for SM8450 GPUCC"), rather than just a fault of 728692d49edc but ab7f00379fe9 was merged first so I just chose 728692d49edc as the problematic commit for the message, feel free to adjust it as necessary. --- drivers/clk/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) --- base-commit: e1cd74b6dccb98ca09e4612ff29c7658db7a487b change-id: 20230829-fix-sm_gpucc_8550-deps-963aa04323f2 Best regards,