| Message ID | 20230908152225.432139-3-vignesh.raman@collabora.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm: ci: fixes | expand |
On Fri, Sep 08, 2023 at 08:52:18PM +0530, Vignesh Raman wrote: > Due to the presence of the fastboot micro cable in the CI farm, > it causes the hardware to remain in gadget mode instead of host mode. > So it doesn't find the network, which results in failure to mount root > fs via NFS. > > Add an overlay dtso file that sets the dr_mode to host, allowing > the USB controllers to work in host mode. This dtso file will be used > in drm-ci, mesa-ci. > > Overlay DT file uses the sugar syntax [suggested by Dmitry Baryshkov and Maxime Ripard] > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Suggested-by: Maxime Ripard <mripard@kernel.org> > Signed-off-by: Helen Koike <helen.koike@collabora.com> > Signed-off-by: David Heidelberg <david.heidelberg@collabora.com> > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > --- > > v3: > - New patch in the series to add device tree overlay in arch/arm64/boot/dts/qcom > > --- > arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso > new file mode 100644 > index 000000000000..a82c26b7eae8 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso > @@ -0,0 +1,8 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +/dts-v1/; > +/plugin/; > + > +&usb { > + dr_mode = "host"; > +}; > -- > 2.40.1 > You need to add it to the Makefile too Maxime
On 08/09/2023 17:22, Vignesh Raman wrote: > Due to the presence of the fastboot micro cable in the CI farm, > it causes the hardware to remain in gadget mode instead of host mode. > So it doesn't find the network, which results in failure to mount root > fs via NFS. > > Add an overlay dtso file that sets the dr_mode to host, allowing > the USB controllers to work in host mode. This dtso file will be used > in drm-ci, mesa-ci. > > Overlay DT file uses the sugar syntax [suggested by Dmitry Baryshkov and Maxime Ripard] > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Suggested-by: Maxime Ripard <mripard@kernel.org> > Signed-off-by: Helen Koike <helen.koike@collabora.com> > Signed-off-by: David Heidelberg <david.heidelberg@collabora.com> > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > --- > > v3: > - New patch in the series to add device tree overlay in arch/arm64/boot/dts/qcom > > --- > arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++ > 1 file changed, 8 insertions(+) Split unrelated patches to separate patchsets. This has nothing to do with DRM CI system. Best regards, Krzysztof
On 8.09.2023 17:22, Vignesh Raman wrote: > Due to the presence of the fastboot micro cable in the CI farm, > it causes the hardware to remain in gadget mode instead of host mode. > So it doesn't find the network, which results in failure to mount root > fs via NFS. > > Add an overlay dtso file that sets the dr_mode to host, allowing > the USB controllers to work in host mode. This dtso file will be used > in drm-ci, mesa-ci. > > Overlay DT file uses the sugar syntax [suggested by Dmitry Baryshkov and Maxime Ripard] > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Suggested-by: Maxime Ripard <mripard@kernel.org> > Signed-off-by: Helen Koike <helen.koike@collabora.com> > Signed-off-by: David Heidelberg <david.heidelberg@collabora.com> > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > --- For such a small change, maybe you can just use sed in your scripts to alter this? Konrad
Hi Konrad, On 11/09/23 17:20, Konrad Dybcio wrote: > On 8.09.2023 17:22, Vignesh Raman wrote: >> Due to the presence of the fastboot micro cable in the CI farm, >> it causes the hardware to remain in gadget mode instead of host mode. >> So it doesn't find the network, which results in failure to mount root >> fs via NFS. >> >> Add an overlay dtso file that sets the dr_mode to host, allowing >> the USB controllers to work in host mode. This dtso file will be used >> in drm-ci, mesa-ci. >> >> Overlay DT file uses the sugar syntax [suggested by Dmitry Baryshkov and Maxime Ripard] >> >> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Suggested-by: Maxime Ripard <mripard@kernel.org> >> Signed-off-by: Helen Koike <helen.koike@collabora.com> >> Signed-off-by: David Heidelberg <david.heidelberg@collabora.com> >> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> >> --- > For such a small change, maybe you can just use sed in your > scripts to alter this? This was the initial idea https://patchwork.kernel.org/project/linux-mediatek/patch/20230825122435.316272-3-vignesh.raman@collabora.com/ Since there was a review comment that CI should not make changes to the source tree before building, we went with DT overlay. Regards, Vignesh
On 08/09/2023 12:22, Vignesh Raman wrote: > Due to the presence of the fastboot micro cable in the CI farm, > it causes the hardware to remain in gadget mode instead of host mode. > So it doesn't find the network, which results in failure to mount root > fs via NFS. > > Add an overlay dtso file that sets the dr_mode to host, allowing > the USB controllers to work in host mode. This dtso file will be used > in drm-ci, mesa-ci. > > Overlay DT file uses the sugar syntax [suggested by Dmitry Baryshkov and Maxime Ripard] > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Suggested-by: Maxime Ripard <mripard@kernel.org> > Signed-off-by: Helen Koike <helen.koike@collabora.com> > Signed-off-by: David Heidelberg <david.heidelberg@collabora.com> > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> Acked-by: Helen Koike <helen.koike@collabora.com> > --- > > v3: > - New patch in the series to add device tree overlay in arch/arm64/boot/dts/qcom > > --- > arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso > new file mode 100644 > index 000000000000..a82c26b7eae8 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso > @@ -0,0 +1,8 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +/dts-v1/; > +/plugin/; > + > +&usb { > + dr_mode = "host"; > +};
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso new file mode 100644 index 000000000000..a82c26b7eae8 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso @@ -0,0 +1,8 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) + +/dts-v1/; +/plugin/; + +&usb { + dr_mode = "host"; +};