| Message ID | 20231002-pm7250b-gpio-fixup-v2-1-debb8b599989@fairphone.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Small updates / fixups for PMIC spmi-gpio | expand |
On Mon, Oct 02, 2023 at 09:00:11AM +0200, Luca Weiss wrote: > There's not much point in having unused labels in the binding example, > so drop them. > > This patch was originally motivated by ea25d61b448a ("arm64: dts: qcom: > Use plural _gpios node label for PMIC gpios") updating all dts files to > use the plural _gpios label instead of the singular _gpio as label but > this example wasn't updated. But since we should just drop the label > alltogether, do that. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > index 55e931ba5b47..9fa568603930 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml > @@ -239,13 +239,13 @@ examples: > interrupt-controller; > #interrupt-cells = <4>; > > - pmi8998_lsid0: pmic@2 { > + pmic@2 { > compatible = "qcom,pmi8998", "qcom,spmi-pmic"; > reg = <0x2 SPMI_USID>; > #address-cells = <1>; > #size-cells = <0>; > > - pmi8998_gpio: gpio@c000 { > + gpio@c000 { > compatible = "qcom,pmi8998-gpio", "qcom,spmi-gpio"; > reg = <0xc000>; > gpio-controller; > @@ -330,7 +330,7 @@ examples: > }; > }; > > - pm6150_gpio: gpio@c000 { > + gpio@c000 { > compatible = "qcom,pm6150-gpio", "qcom,spmi-gpio"; > reg = <0xc000>; > gpio-controller; > > -- > 2.42.0 >
On 02/10/2023 09:00, Luca Weiss wrote: > There's not much point in having unused labels in the binding example, > so drop them. > > This patch was originally motivated by ea25d61b448a ("arm64: dts: qcom: > Use plural _gpios node label for PMIC gpios") updating all dts files to > use the plural _gpios label instead of the singular _gpio as label but > this example wasn't updated. But since we should just drop the label > alltogether, do that. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, 02 Oct 2023 09:00:11 +0200, Luca Weiss wrote: > There's not much point in having unused labels in the binding example, > so drop them. > > This patch was originally motivated by ea25d61b448a ("arm64: dts: qcom: > Use plural _gpios node label for PMIC gpios") updating all dts files to > use the plural _gpios label instead of the singular _gpio as label but > this example wasn't updated. But since we should just drop the label > alltogether, do that. > > [...] Applied, thanks! [1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples commit: cac94656ff2b16827d7cd455f0d3746280cf3138 -- Lee Jones [李琼斯]
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 55e931ba5b47..9fa568603930 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -239,13 +239,13 @@ examples: interrupt-controller; #interrupt-cells = <4>; - pmi8998_lsid0: pmic@2 { + pmic@2 { compatible = "qcom,pmi8998", "qcom,spmi-pmic"; reg = <0x2 SPMI_USID>; #address-cells = <1>; #size-cells = <0>; - pmi8998_gpio: gpio@c000 { + gpio@c000 { compatible = "qcom,pmi8998-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller; @@ -330,7 +330,7 @@ examples: }; }; - pm6150_gpio: gpio@c000 { + gpio@c000 { compatible = "qcom,pm6150-gpio", "qcom,spmi-gpio"; reg = <0xc000>; gpio-controller;
There's not much point in having unused labels in the binding example, so drop them. This patch was originally motivated by ea25d61b448a ("arm64: dts: qcom: Use plural _gpios node label for PMIC gpios") updating all dts files to use the plural _gpios label instead of the singular _gpio as label but this example wasn't updated. But since we should just drop the label alltogether, do that. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)