| Message ID | 20231016155537.2973625-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | dt-bindings: soundwire: Add reference to soundwire-controller.yaml schema | expand |
On 16/10/2023 17:55, Rob Herring wrote: > The soundwire-controller.yaml schema already defines the form for devices > in child nodes, so there's no need to do the same in the QCom controller > binding. Add a $ref to the soundwire-controller.yaml schema and drop the > child node schema. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, 16 Oct 2023 10:55:37 -0500, Rob Herring wrote: > The soundwire-controller.yaml schema already defines the form for devices > in child nodes, so there's no need to do the same in the QCom controller > binding. Add a $ref to the soundwire-controller.yaml schema and drop the > child node schema. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../bindings/soundwire/qcom,soundwire.yaml | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml index 7d60a9654912..3591c8c49bfe 100644 --- a/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml +++ b/Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml @@ -209,17 +209,6 @@ properties: label: maxItems: 1 -patternProperties: - "^.*@[0-9a-f],[0-9a-f]$": - type: object - additionalProperties: true - description: - Child nodes for a standalone audio codec or speaker amplifier IC. - It has RX and TX Soundwire secondary devices. - properties: - compatible: - pattern: "^sdw[0-9a-f]{1}[0-9a-f]{4}[0-9a-f]{4}[0-9a-f]{2}$" - required: - compatible - reg @@ -240,7 +229,10 @@ oneOf: - required: - qcom,ports-sinterval -additionalProperties: false +allOf: + - $ref: soundwire-controller.yaml# + +unevaluatedProperties: false examples: - |
The soundwire-controller.yaml schema already defines the form for devices in child nodes, so there's no need to do the same in the QCom controller binding. Add a $ref to the soundwire-controller.yaml schema and drop the child node schema. Signed-off-by: Rob Herring <robh@kernel.org> --- .../bindings/soundwire/qcom,soundwire.yaml | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-)