| Message ID | 20231102-b4-camss-sc8280xp-v1-6-9996f4bcb8f4@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: qcom: camss: Add sc8280xp support | expand |
On 02/11/2023 12:41, Bryan O'Donoghue wrote: > vfe-170 and vfe-175 can be supported in the same file with some minimal > indirection to differentiate between the silicon versions. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- But you directly assigned v170 to sc8280xp, without any renaming or meaningful changes I think? Konrad
On 02/11/2023 13:40, Konrad Dybcio wrote: > > > On 02/11/2023 12:41, Bryan O'Donoghue wrote: >> vfe-170 and vfe-175 can be supported in the same file with some minimal >> indirection to differentiate between the silicon versions. >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- > But you directly assigned v170 to sc8280xp, without any renaming or > meaningful changes I think? > > Konrad The specific version for sc8280xp is 175-200 => the motivation for the name change. I'll amend the log to reflect. --- bod
diff --git a/drivers/media/platform/qcom/camss/Makefile b/drivers/media/platform/qcom/camss/Makefile index 4e22223589739..0d4389ab312d1 100644 --- a/drivers/media/platform/qcom/camss/Makefile +++ b/drivers/media/platform/qcom/camss/Makefile @@ -14,7 +14,7 @@ qcom-camss-objs += \ camss-vfe-4-1.o \ camss-vfe-4-7.o \ camss-vfe-4-8.o \ - camss-vfe-170.o \ + camss-vfe-17x.o \ camss-vfe-480.o \ camss-vfe-gen1.o \ camss-vfe.o \ diff --git a/drivers/media/platform/qcom/camss/camss-vfe-170.c b/drivers/media/platform/qcom/camss/camss-vfe-17x.c similarity index 100% rename from drivers/media/platform/qcom/camss/camss-vfe-170.c rename to drivers/media/platform/qcom/camss/camss-vfe-17x.c
vfe-170 and vfe-175 can be supported in the same file with some minimal indirection to differentiate between the silicon versions. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- drivers/media/platform/qcom/camss/Makefile | 2 +- drivers/media/platform/qcom/camss/{camss-vfe-170.c => camss-vfe-17x.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-)