| Message ID | 20231117104254.28862-3-quic_sibis@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | pmdomain: qcom: Update part number to X1E80100 | expand |
On 17/11/2023 11:42, Sibi Sankar wrote: > Replace SC8380xp with the updated part number (X1E80100). > > Fixes: 2050c9bc4f7b ("pmdomain: qcom: rpmhpd: Add SC8380XP power domains") No, there was no bug or at least you did not describe a bug. If it was a bug, please define it in the commit msg. Best regards, Krzysztof
Hey Krzysztof, On 11/17/23 16:36, Krzysztof Kozlowski wrote: > On 17/11/2023 11:42, Sibi Sankar wrote: >> Replace SC8380xp with the updated part number (X1E80100). >> >> Fixes: 2050c9bc4f7b ("pmdomain: qcom: rpmhpd: Add SC8380XP power domains") > > No, there was no bug or at least you did not describe a bug. If it was a > bug, please define it in the commit msg. It's technically replacing an obsolete part number with the correct on, so I thought using the fixes tag makes sense. Let me add more details on the next re-spin. -Sibi > > Best regards, > Krzysztof > >
On 17/11/2023 12:50, Sibi Sankar wrote: > Hey Krzysztof, > > > On 11/17/23 16:36, Krzysztof Kozlowski wrote: >> On 17/11/2023 11:42, Sibi Sankar wrote: >>> Replace SC8380xp with the updated part number (X1E80100). >>> >>> Fixes: 2050c9bc4f7b ("pmdomain: qcom: rpmhpd: Add SC8380XP power domains") >> >> No, there was no bug or at least you did not describe a bug. If it was a >> bug, please define it in the commit msg. > > It's technically replacing an obsolete part number with the correct > on, so I thought using the fixes tag makes sense. Let me add more > details on the next re-spin. You are not replacing any obsolete device. It's purely naming style, so no, that's not a valid reason for a fix. Drop fixes tag from both patches. Best regards, Krzysztof
diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c index f2e64324deb8..3078896b1300 100644 --- a/drivers/pmdomain/qcom/rpmhpd.c +++ b/drivers/pmdomain/qcom/rpmhpd.c @@ -598,8 +598,8 @@ static const struct rpmhpd_desc sc8280xp_desc = { .num_pds = ARRAY_SIZE(sc8280xp_rpmhpds), }; -/* SC8380xp RPMH powerdomains */ -static struct rpmhpd *sc8380xp_rpmhpds[] = { +/* X1E80100 RPMH powerdomains */ +static struct rpmhpd *x1e80100_rpmhpds[] = { [RPMHPD_CX] = &cx, [RPMHPD_CX_AO] = &cx_ao, [RPMHPD_EBI] = &ebi, @@ -615,9 +615,9 @@ static struct rpmhpd *sc8380xp_rpmhpds[] = { [RPMHPD_GMXC] = &gmxc, }; -static const struct rpmhpd_desc sc8380xp_desc = { - .rpmhpds = sc8380xp_rpmhpds, - .num_pds = ARRAY_SIZE(sc8380xp_rpmhpds), +static const struct rpmhpd_desc x1e80100_desc = { + .rpmhpds = x1e80100_rpmhpds, + .num_pds = ARRAY_SIZE(x1e80100_rpmhpds), }; static const struct of_device_id rpmhpd_match_table[] = { @@ -629,7 +629,6 @@ static const struct of_device_id rpmhpd_match_table[] = { { .compatible = "qcom,sc7280-rpmhpd", .data = &sc7280_desc }, { .compatible = "qcom,sc8180x-rpmhpd", .data = &sc8180x_desc }, { .compatible = "qcom,sc8280xp-rpmhpd", .data = &sc8280xp_desc }, - { .compatible = "qcom,sc8380xp-rpmhpd", .data = &sc8380xp_desc }, { .compatible = "qcom,sdm670-rpmhpd", .data = &sdm670_desc }, { .compatible = "qcom,sdm845-rpmhpd", .data = &sdm845_desc }, { .compatible = "qcom,sdx55-rpmhpd", .data = &sdx55_desc}, @@ -643,6 +642,7 @@ static const struct of_device_id rpmhpd_match_table[] = { { .compatible = "qcom,sm8450-rpmhpd", .data = &sm8450_desc }, { .compatible = "qcom,sm8550-rpmhpd", .data = &sm8550_desc }, { .compatible = "qcom,sm8650-rpmhpd", .data = &sm8650_desc }, + { .compatible = "qcom,x1e80100-rpmhpd", .data = &x1e80100_desc }, { } }; MODULE_DEVICE_TABLE(of, rpmhpd_match_table);
Replace SC8380xp with the updated part number (X1E80100). Fixes: 2050c9bc4f7b ("pmdomain: qcom: rpmhpd: Add SC8380XP power domains") Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> --- drivers/pmdomain/qcom/rpmhpd.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)