| Message ID | 20231119112826.5115-15-hkallweit1@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | remove I2C_CLASS_DDC support | expand |
On Sun, 19 Nov 2023 at 13:28, Heiner Kallweit <hkallweit1@gmail.com> wrote: > > After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in > olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. > Class-based device auto-detection is a legacy mechanism and shouldn't > be used in new code. So we can remove this class completely now. > > Preferably this series should be applied via the i2c tree. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> I'm fine with merging this patch through any of the trees that picks up the rest of the patches. > > --- > drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c > index de182c004..7aa500d24 100644 > --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c > +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c > @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) > > > i2c->owner = THIS_MODULE; > - i2c->class = I2C_CLASS_DDC; > snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); > i2c->dev.parent = &hdmi->pdev->dev; > i2c->algo = &msm_hdmi_i2c_algorithm; >
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c index de182c004..7aa500d24 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) i2c->owner = THIS_MODULE; - i2c->class = I2C_CLASS_DDC; snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); i2c->dev.parent = &hdmi->pdev->dev; i2c->algo = &msm_hdmi_i2c_algorithm;
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-)