| Message ID | 20231122-phy-qualcomm-eusb2-x1e80100-v1-2-ce0991161847@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | phy: qcom: snps-eusb2: Add support for X1E80100 | expand |
On Wed, 22 Nov 2023 at 12:28, Abel Vesa <abel.vesa@linaro.org> wrote: > > Add the X1E80100 to the list of supported PHYs for eUSB2 > SNPS driver. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c > index 1484691a41d5..6420f342dc85 100644 > --- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c > +++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c > @@ -425,6 +425,7 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev) > > static const struct of_device_id qcom_snps_eusb2_hsphy_of_match_table[] = { > { .compatible = "qcom,sm8550-snps-eusb2-phy", }, > + { .compatible = "qcom,x1e80100-snps-eusb2-phy", }, Do we need a separate compatible string or is it fully compatible with sm8550? If it is the same IP block, maybe you can use a fallback compatible instead? > { }, > }; > MODULE_DEVICE_TABLE(of, qcom_snps_eusb2_hsphy_of_match_table); > > -- > 2.34.1 > >
On 22/11/2023 12:01, Dmitry Baryshkov wrote: > On Wed, 22 Nov 2023 at 12:28, Abel Vesa <abel.vesa@linaro.org> wrote: >> >> Add the X1E80100 to the list of supported PHYs for eUSB2 >> SNPS driver. >> >> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >> --- >> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c >> index 1484691a41d5..6420f342dc85 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c >> +++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c >> @@ -425,6 +425,7 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev) >> >> static const struct of_device_id qcom_snps_eusb2_hsphy_of_match_table[] = { >> { .compatible = "qcom,sm8550-snps-eusb2-phy", }, >> + { .compatible = "qcom,x1e80100-snps-eusb2-phy", }, > > Do we need a separate compatible string or is it fully compatible with > sm8550? If it is the same IP block, maybe you can use a fallback > compatible instead? Yep. This should use fallback. Best regards, Krzysztof
diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c index 1484691a41d5..6420f342dc85 100644 --- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c @@ -425,6 +425,7 @@ static int qcom_snps_eusb2_hsphy_probe(struct platform_device *pdev) static const struct of_device_id qcom_snps_eusb2_hsphy_of_match_table[] = { { .compatible = "qcom,sm8550-snps-eusb2-phy", }, + { .compatible = "qcom,x1e80100-snps-eusb2-phy", }, { }, }; MODULE_DEVICE_TABLE(of, qcom_snps_eusb2_hsphy_of_match_table);
Add the X1E80100 to the list of supported PHYs for eUSB2 SNPS driver. Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 1 + 1 file changed, 1 insertion(+)