| Message ID | 20231124135713.5610-2-lujianhua000@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: sm8250-xiaomi-elish: Fix typos | expand |
On 24/11/2023 14:57, Jianhua Lu wrote: > ufs node isn't in a right place, 'f' is front of 's', so move it to > above usb node. Please not. If we change the order to match DTSI, then this patch would be wrong. Best regards, Krzysztof
On Fri, Nov 24, 2023 at 04:54:20PM +0100, Krzysztof Kozlowski wrote: > On 24/11/2023 14:57, Jianhua Lu wrote: > > ufs node isn't in a right place, 'f' is front of 's', so move it to > > above usb node. > > Please not. > > If we change the order to match DTSI, then this patch would be wrong. > Acked. I will drop this patch. > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi index 3d4ea428e4cb..3de7cb918448 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi @@ -657,6 +657,22 @@ &tlmm { gpio-reserved-ranges = <40 4>; }; +&ufs_mem_hc { + vcc-supply = <&vreg_l17a_3p0>; + vcc-max-microamp = <800000>; + vccq-supply = <&vreg_l6a_1p2>; + vccq-max-microamp = <800000>; + vccq2-supply = <&vreg_s4a_1p8>; + vccq2-max-microamp = <800000>; + status = "okay"; +}; + +&ufs_mem_phy { + vdda-phy-supply = <&vreg_l5a_0p88>; + vdda-pll-supply = <&vreg_l9a_1p2>; + status = "okay"; +}; + &usb_1 { /* USB 2.0 only */ qcom,select-utmi-as-pipe-clk; @@ -678,22 +694,6 @@ &usb_1_hsphy { status = "okay"; }; -&ufs_mem_hc { - vcc-supply = <&vreg_l17a_3p0>; - vcc-max-microamp = <800000>; - vccq-supply = <&vreg_l6a_1p2>; - vccq-max-microamp = <800000>; - vccq2-supply = <&vreg_s4a_1p8>; - vccq2-max-microamp = <800000>; - status = "okay"; -}; - -&ufs_mem_phy { - vdda-phy-supply = <&vreg_l5a_0p88>; - vdda-pll-supply = <&vreg_l9a_1p2>; - status = "okay"; -}; - &venus { firmware-name = "qcom/sm8250/xiaomi/elish/venus.mbn"; status = "okay";
ufs node isn't in a right place, 'f' is front of 's', so move it to above usb node. Signed-off-by: Jianhua Lu <lujianhua000@gmail.com> --- .../dts/qcom/sm8250-xiaomi-elish-common.dtsi | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-)