| Message ID | 20231129121841.253223-7-vignesh.raman@collabora.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drm: ci: fixes | expand |
Hi Vignesh, On Wed, 29 Nov 2023 at 12:19, Vignesh Raman <vignesh.raman@collabora.com> wrote: > Expected driver for mt8173 is "mediatek" and for mt8183 > it is "panfrost". Set IGT_FORCE_DRIVER to 'mediatek' as > the expected driver for mt8173. Actually, for mt8183 it's both. And for mt8173 it will probably be mediatek+pvr pretty soon. Each of these SoCs (like most Arm devices) have a separate display controller and GPU, with different drivers for each. They'll run different tests with different xfails. So we should figure out a way to support igt running for both devices on the one system. Cheers, Daniel
Hi Daniel, On 29/11/23 18:52, Daniel Stone wrote: > Hi Vignesh, > > On Wed, 29 Nov 2023 at 12:19, Vignesh Raman <vignesh.raman@collabora.com> wrote: >> Expected driver for mt8173 is "mediatek" and for mt8183 >> it is "panfrost". Set IGT_FORCE_DRIVER to 'mediatek' as >> the expected driver for mt8173. > > Actually, for mt8183 it's both. And for mt8173 it will probably be > mediatek+pvr pretty soon. Each of these SoCs (like most Arm devices) > have a separate display controller and GPU, with different drivers for > each. They'll run different tests with different xfails. So we should > figure out a way to support igt running for both devices on the one > system. Agree. Will work on separate patch to test both the drivers for these devices. Regards, Vignesh
Hi, Thanks for your patch. On 29/11/2023 09:18, Vignesh Raman wrote: > Expected driver for mt8173 is "mediatek" and for mt8183 > it is "panfrost". Set IGT_FORCE_DRIVER to 'mediatek' as > the expected driver for mt8173. > > Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> > --- > > v5: > - Added a new patch in the series to set IGT_FORCE_DRIVER to 'mediatek' for mt8173 > > v6: > - Use GPU_VERSION instead of CI_JOB_NAME to check if it is mt8173 > > --- > drivers/gpu/drm/ci/igt_runner.sh | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh > index c6cf963592c5..70a0f84021a1 100755 > --- a/drivers/gpu/drm/ci/igt_runner.sh > +++ b/drivers/gpu/drm/ci/igt_runner.sh > @@ -30,6 +30,10 @@ case "$DRIVER_NAME" in > ;; > esac > > +if [ "$GPU_VERSION" = "mt8173" ]; then > + export IGT_FORCE_DRIVER=${DRIVER_NAME} > +fi Just a nit, could you add this in the first case statement? Just to avoid confusing about double assignment? -> but feel free to ignore this comment. With or without this: Acked-by: Helen Koike <helen.koike@collabora.com> Thanks Helen > + > if [ -e "/install/xfails/$DRIVER_NAME-$GPU_VERSION-skips.txt" ]; then > IGT_SKIPS="--skips /install/xfails/$DRIVER_NAME-$GPU_VERSION-skips.txt" > fi
diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh index c6cf963592c5..70a0f84021a1 100755 --- a/drivers/gpu/drm/ci/igt_runner.sh +++ b/drivers/gpu/drm/ci/igt_runner.sh @@ -30,6 +30,10 @@ case "$DRIVER_NAME" in ;; esac +if [ "$GPU_VERSION" = "mt8173" ]; then + export IGT_FORCE_DRIVER=${DRIVER_NAME} +fi + if [ -e "/install/xfails/$DRIVER_NAME-$GPU_VERSION-skips.txt" ]; then IGT_SKIPS="--skips /install/xfails/$DRIVER_NAME-$GPU_VERSION-skips.txt" fi
Expected driver for mt8173 is "mediatek" and for mt8183 it is "panfrost". Set IGT_FORCE_DRIVER to 'mediatek' as the expected driver for mt8173. Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com> --- v5: - Added a new patch in the series to set IGT_FORCE_DRIVER to 'mediatek' for mt8173 v6: - Use GPU_VERSION instead of CI_JOB_NAME to check if it is mt8173 --- drivers/gpu/drm/ci/igt_runner.sh | 4 ++++ 1 file changed, 4 insertions(+)