| Message ID | 20231204094649.10094-1-matti.lehtimaki@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ffb05e91b68bc58484b94b5d3d1aa8e559278fd6 |
| Headers | show |
| Series | ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys | expand |
On 4.12.2023 10:46, Matti Lehtimäki wrote: > Add touch keys which are handled in touchscreen driver. > Use KEY_APPSELECT for the left button because other devices use that > even though downstream kernel uses KEY_RECENT. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Montag, 4. Dezember 2023 10:46:49 CET Matti Lehtimäki wrote: > Add touch keys which are handled in touchscreen driver. > Use KEY_APPSELECT for the left button because other devices use that > even though downstream kernel uses KEY_RECENT. > > Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> > --- > .../boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts > b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts index > f516e0426bb9..8a2ba2aadf23 100644 > --- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts > +++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts > @@ -268,6 +268,13 @@ touchscreen@4a { > interrupt-parent = <&tlmm>; > interrupts = <17 IRQ_TYPE_LEVEL_LOW>; > > + linux,keycodes = <KEY_RESERVED > + KEY_RESERVED > + KEY_RESERVED > + KEY_RESERVED > + KEY_APPSELECT > + KEY_BACK>; Might be prettier like this since it's 6 items you're adding, not one long property? linux,keycodes = <KEY_RESERVED>, <KEY_RESERVED>, <KEY_RESERVED>, <KEY_RESERVED>, <KEY_APPSELECT>, <KEY_BACK>; Resulting dtb should be the same, so it's just a stylistic thing. In any case: Reviewed-by: Luca Weiss <luca@z3ntu.xyz> > + > pinctrl-names = "default"; > pinctrl-0 = <&tsp_int_rst_default_state>;
On Mon, 04 Dec 2023 11:46:49 +0200, Matti Lehtimäki wrote: > Add touch keys which are handled in touchscreen driver. > Use KEY_APPSELECT for the left button because other devices use that > even though downstream kernel uses KEY_RECENT. > > Applied, thanks! [1/1] ARM: dts: qcom: apq8026-samsung-matissewifi: Configure touch keys commit: ffb05e91b68bc58484b94b5d3d1aa8e559278fd6 Best regards,
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts index f516e0426bb9..8a2ba2aadf23 100644 --- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts +++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts @@ -268,6 +268,13 @@ touchscreen@4a { interrupt-parent = <&tlmm>; interrupts = <17 IRQ_TYPE_LEVEL_LOW>; + linux,keycodes = <KEY_RESERVED + KEY_RESERVED + KEY_RESERVED + KEY_RESERVED + KEY_APPSELECT + KEY_BACK>; + pinctrl-names = "default"; pinctrl-0 = <&tsp_int_rst_default_state>;
Add touch keys which are handled in touchscreen driver. Use KEY_APPSELECT for the left button because other devices use that even though downstream kernel uses KEY_RECENT. Signed-off-by: Matti Lehtimäki <matti.lehtimaki@gmail.com> --- .../boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts | 7 +++++++ 1 file changed, 7 insertions(+)