| Message ID | 20231205082922.32149-3-quic_jinlmao@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: Fix the warnings from coresight bindings | expand |
On 12/5/23 09:29, Mao Jinlong wrote: > Add the inport of funnel@3023000 to fix 'in-ports' is a required property > warning. > > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 6ba9da9e6a8b..e7d93d0b4f3b 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -444,6 +444,20 @@ memory@80000000 { > reg = <0x0 0x80000000 0x0 0x0>; > }; > > + modem-etm0 { > + compatible = "qcom,coresight-remote-etm"; > + > + qcom,inst-id = <2>; > + out-ports { > + port { > + modem_etm_out_funnel_in2: endpoint{ Nit: missing space between 'endpoint' and the opening brace Konrad
On 05/12/2023 09:29, Mao Jinlong wrote: > Add the inport of funnel@3023000 to fix 'in-ports' is a required property > warning. > > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 6ba9da9e6a8b..e7d93d0b4f3b 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -444,6 +444,20 @@ memory@80000000 { > reg = <0x0 0x80000000 0x0 0x0>; > }; > > + modem-etm0 { etm { or etm-0 { Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 6ba9da9e6a8b..e7d93d0b4f3b 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -444,6 +444,20 @@ memory@80000000 { reg = <0x0 0x80000000 0x0 0x0>; }; + modem-etm0 { + compatible = "qcom,coresight-remote-etm"; + + qcom,inst-id = <2>; + out-ports { + port { + modem_etm_out_funnel_in2: endpoint{ + remote-endpoint = + <&funnel_in2_in_modem_etm>; + }; + }; + }; + }; + psci { compatible = "arm,psci-1.0"; method = "smc"; @@ -2644,6 +2658,14 @@ funnel@3023000 { clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>; clock-names = "apb_pclk", "atclk"; + in-ports { + port { + funnel_in2_in_modem_etm: endpoint{ + remote-endpoint = + <&modem_etm_out_funnel_in2>; + }; + }; + }; out-ports { port {
Add the inport of funnel@3023000 to fix 'in-ports' is a required property warning. Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)