| Message ID | 20240111-topic-sm8650-upstream-qrd-fix-gpio-reserved-v1-2-fad39b4c5def@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | df77288f7e3accf246785c53cd5f117fc5d81611 |
| Headers | show |
| Series | arm64: dts: qcom: sm8650: mark gpio74 as reserved | expand |
On 1/11/24 17:58, Neil Armstrong wrote: > The TLMM gpio74 is also used to communicate with the secure NFC > on-board module, some variants of the SM8650-MTP board requires > this GPIO to be dedicated to the secure firmware and set reserved > in order to successfully initialize the TLMM GPIOs from HLOS (Linux). > On the other boards this GPIO is unused so it's still safe to mark > the GPIO as reserved. > > Fixes: 6fbdb3c1fac7 ("arm64: dts: qcom: sm8650: add initial SM8650 MTP dts") > Reported-by: Georgi Djakov <djakov@kernel.org> > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On 1/11/2024 6:58 PM, Neil Armstrong wrote: > The TLMM gpio74 is also used to communicate with the secure NFC > on-board module, some variants of the SM8650-MTP board requires > this GPIO to be dedicated to the secure firmware and set reserved > in order to successfully initialize the TLMM GPIOs from HLOS (Linux). > On the other boards this GPIO is unused so it's still safe to mark > the GPIO as reserved. > > Fixes: 6fbdb3c1fac7 ("arm64: dts: qcom: sm8650: add initial SM8650 MTP dts") > Reported-by: Georgi Djakov <djakov@kernel.org> > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> The SM8650-MTP board boots successfully with this patch. Thanks Neil! Tested-by: Georgi Djakov <quic_c_gdjako@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts > index 9d916edb1c73..be133a3d5cbe 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts > @@ -622,7 +622,7 @@ right_spkr: speaker@0,1 { > > &tlmm { > /* Reserved I/Os for NFC */ > - gpio-reserved-ranges = <32 8>; > + gpio-reserved-ranges = <32 8>, <74 1>; > > disp0_reset_n_active: disp0-reset-n-active-state { > pins = "gpio133"; >
diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts index 9d916edb1c73..be133a3d5cbe 100644 --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts @@ -622,7 +622,7 @@ right_spkr: speaker@0,1 { &tlmm { /* Reserved I/Os for NFC */ - gpio-reserved-ranges = <32 8>; + gpio-reserved-ranges = <32 8>, <74 1>; disp0_reset_n_active: disp0-reset-n-active-state { pins = "gpio133";
The TLMM gpio74 is also used to communicate with the secure NFC on-board module, some variants of the SM8650-MTP board requires this GPIO to be dedicated to the secure firmware and set reserved in order to successfully initialize the TLMM GPIOs from HLOS (Linux). On the other boards this GPIO is unused so it's still safe to mark the GPIO as reserved. Fixes: 6fbdb3c1fac7 ("arm64: dts: qcom: sm8650: add initial SM8650 MTP dts") Reported-by: Georgi Djakov <djakov@kernel.org> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)