| Message ID | 20240115164252.26510-3-quic_jinlmao@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | coresight: core: Add device name support | expand |
On Mon, 15 Jan 2024 08:42:48 -0800, Mao Jinlong wrote: > device-name is used to provide a better description of the coresight > device. It can provide the info like the system or HW it belongs to. > > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > .../devicetree/bindings/arm/arm,coresight-catu.yaml | 5 +++++ > .../devicetree/bindings/arm/arm,coresight-cpu-debug.yaml | 5 +++++ > Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml | 5 +++++ > .../devicetree/bindings/arm/arm,coresight-dummy-sink.yaml | 5 +++++ > .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 5 +++++ > .../bindings/arm/arm,coresight-dynamic-funnel.yaml | 5 +++++ > .../bindings/arm/arm,coresight-dynamic-replicator.yaml | 5 +++++ > .../devicetree/bindings/arm/arm,coresight-etb10.yaml | 5 +++++ > Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml | 5 +++++ > .../devicetree/bindings/arm/arm,coresight-static-funnel.yaml | 5 +++++ > .../bindings/arm/arm,coresight-static-replicator.yaml | 5 +++++ > Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml | 5 +++++ > Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml | 5 +++++ > .../devicetree/bindings/arm/arm,coresight-tpiu.yaml | 5 +++++ > .../devicetree/bindings/arm/qcom,coresight-tpda.yaml | 5 +++++ > .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 5 +++++ > 16 files changed, 80 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml: device-name: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240115164252.26510-3-quic_jinlmao@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 15/01/2024 17:42, Mao Jinlong wrote: > device-name is used to provide a better description of the coresight > device. It can provide the info like the system or HW it belongs to. > system or HW are defined by top level model, so probably you meant here something else. Anyway you need to provide better rationale, because above argument can be applied to any device and we do not have generic device-name property. Once you have good explanation, then probably you want "label" not some new property. Best regards, Krzysztof
Hi Mao,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.7 next-20240112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mao-Jinlong/coresight-core-Add-device-name-support/20240116-004557
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20240115164252.26510-3-quic_jinlmao%40quicinc.com
patch subject: [PATCH v2 2/2] dt-bindings: arm: Add device-name in the coresight components
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20240117/202401170445.7STzlFcl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401170445.7STzlFcl-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml: device-name: missing type definition
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml index 2bae06eed693..313e25d62f0d 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml @@ -44,6 +44,11 @@ properties: - const: arm,coresight-catu - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml index 0a6bc03ebe00..f7904a7df726 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml @@ -39,6 +39,11 @@ properties: - const: arm,coresight-cpu-debug - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml index 2d5545a2b49c..ba7b4e2db77c 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml @@ -88,6 +88,11 @@ properties: - const: arm,coresight-cti - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-sink.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-sink.yaml index c960c8e0a9a5..f94e08ca91f0 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-sink.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-sink.yaml @@ -39,6 +39,11 @@ properties: enum: - arm,coresight-dummy-sink + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + in-ports: $ref: /schemas/graph.yaml#/properties/ports diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml index 6745b4cc8f1c..031c4a1cb199 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml @@ -38,6 +38,11 @@ properties: enum: - arm,coresight-dummy-source + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + out-ports: $ref: /schemas/graph.yaml#/properties/ports diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml index 44a1041cb0fc..2b4829492218 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml @@ -41,6 +41,11 @@ properties: - const: arm,coresight-dynamic-funnel - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-replicator.yaml index 03792e9bd97a..c841db363a87 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-replicator.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-replicator.yaml @@ -41,6 +41,11 @@ properties: - const: arm,coresight-dynamic-replicator - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml index 90679788e0bf..6605a8097a14 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml @@ -41,6 +41,11 @@ properties: - const: arm,coresight-etb10 - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml index 01200f67504a..d9ab0fc57f72 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml @@ -60,6 +60,11 @@ properties: Embedded Trace Macrocell (version 4.x), with system register access only const: arm,coresight-etm4x-sysreg + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml index cc8c3baa79b4..342dfb303072 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml @@ -27,6 +27,11 @@ properties: compatible: const: arm,coresight-static-funnel + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + power-domains: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml index 1892a091ac35..eaa828124c58 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml @@ -27,6 +27,11 @@ properties: compatible: const: arm,coresight-static-replicator + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + power-domains: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml index 378380c3f5aa..9bc49fed2096 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml @@ -43,6 +43,11 @@ properties: - const: arm,coresight-stm - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: maxItems: 2 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml index cb8dceaca70e..ba1dec0f580a 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml @@ -42,6 +42,11 @@ properties: - const: arm,coresight-tmc - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml index 61a0cdc27745..6a5d0c3468f7 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml @@ -41,6 +41,11 @@ properties: - const: arm,coresight-tpiu - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: maxItems: 1 diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml index ea3c5db6b52d..31b7d7471a23 100644 --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpda.yaml @@ -54,6 +54,11 @@ properties: - const: qcom,coresight-tpda - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: minItems: 1 maxItems: 2 diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml index 3bad47b7b02b..3b72ca36636e 100644 --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml @@ -40,6 +40,11 @@ properties: - const: qcom,coresight-tpdm - const: arm,primecell + device-name: + description: + Define the name which can describe what kind of HW or system the + device is for. + reg: minItems: 1 maxItems: 2
device-name is used to provide a better description of the coresight device. It can provide the info like the system or HW it belongs to. Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> --- .../devicetree/bindings/arm/arm,coresight-catu.yaml | 5 +++++ .../devicetree/bindings/arm/arm,coresight-cpu-debug.yaml | 5 +++++ Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml | 5 +++++ .../devicetree/bindings/arm/arm,coresight-dummy-sink.yaml | 5 +++++ .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 5 +++++ .../bindings/arm/arm,coresight-dynamic-funnel.yaml | 5 +++++ .../bindings/arm/arm,coresight-dynamic-replicator.yaml | 5 +++++ .../devicetree/bindings/arm/arm,coresight-etb10.yaml | 5 +++++ Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml | 5 +++++ .../devicetree/bindings/arm/arm,coresight-static-funnel.yaml | 5 +++++ .../bindings/arm/arm,coresight-static-replicator.yaml | 5 +++++ Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml | 5 +++++ Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml | 5 +++++ .../devicetree/bindings/arm/arm,coresight-tpiu.yaml | 5 +++++ .../devicetree/bindings/arm/qcom,coresight-tpda.yaml | 5 +++++ .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 5 +++++ 16 files changed, 80 insertions(+)