diff mbox series

ARM: dts: qcom: msm8926-htc-memul: Add rmtfs memory node

Message ID 20240121-memul-rmtfs-v1-1-e9da29b1f856@z3ntu.xyz (mailing list archive)
State Accepted
Commit 713bc594c6334a36d0caf4b98510ba3b6795616a
Headers show
Series ARM: dts: qcom: msm8926-htc-memul: Add rmtfs memory node | expand

Commit Message

Luca Weiss Jan. 21, 2024, 10:21 a.m. UTC
Add the rmtfs-mem node which was part of one of the "unknown" memory
reservation. Split that one, make sure the reserved-memory in total
still covers the same space.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)


---
base-commit: ad5c60d66016e544c51ed98635a74073f761f45d
change-id: 20240121-memul-rmtfs-9aa9b54f200a

Best regards,

Comments

Konrad Dybcio Jan. 22, 2024, 10:53 a.m. UTC | #1
On 21.01.2024 11:21, Luca Weiss wrote:
> Add the rmtfs-mem node which was part of one of the "unknown" memory
> reservation. Split that one, make sure the reserved-memory in total
> still covers the same space.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---

Could you please test dynamic rmtfs alloc, which should be possible
on some (most?) boards after 9265bc6bce6919c771970e5a425a66551a1c78a0?

Konrad
Luca Weiss Jan. 22, 2024, 5:11 p.m. UTC | #2
On Montag, 22. Jänner 2024 11:53:33 CET Konrad Dybcio wrote:
> On 21.01.2024 11:21, Luca Weiss wrote:
> > Add the rmtfs-mem node which was part of one of the "unknown" memory
> > reservation. Split that one, make sure the reserved-memory in total
> > still covers the same space.
> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> 
> Could you please test dynamic rmtfs alloc, which should be possible
> on some (most?) boards after 9265bc6bce6919c771970e5a425a66551a1c78a0?

To be honest, I'd like to not continue to experiment with reserved-memory on 
this board, I've already spent way too much time figuring out how to not make 
the phone crash under some circumstances, and now it seems relatively stable.
I might've even put my eMMC into some weird read-only mode where any write to 
it just weirdly fails (also original software) by writing to random locations 
in the RAM (or well, what Linux thought was non-special RAM).

Regards
Luca

> 
> Konrad
Bjorn Andersson Jan. 28, 2024, 5:45 p.m. UTC | #3
On Sun, 21 Jan 2024 11:21:54 +0100, Luca Weiss wrote:
> Add the rmtfs-mem node which was part of one of the "unknown" memory
> reservation. Split that one, make sure the reserved-memory in total
> still covers the same space.
> 
> 

Applied, thanks!

[1/1] ARM: dts: qcom: msm8926-htc-memul: Add rmtfs memory node
      commit: 713bc594c6334a36d0caf4b98510ba3b6795616a

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
index ed328b24335f..3037344eb240 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-htc-memul.dts
@@ -107,7 +107,20 @@  smem_region: smem@fa00000 {
 		};
 
 		unknown@fb00000 {
-			reg = <0x0fb00000 0x1b00000>;
+			reg = <0x0fb00000 0x280000>;
+			no-map;
+		};
+
+		rmtfs@fd80000 {
+			compatible = "qcom,rmtfs-mem";
+			reg = <0x0fd80000 0x180000>;
+			no-map;
+
+			qcom,client-id = <1>;
+		};
+
+		unknown@ff00000 {
+			reg = <0x0ff00000 0x1700000>;
 			no-map;
 		};
 	};