| Message ID | 20240229013503.483651-1-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | 9f618cdce29d7bef10c2f4c8cbf58bc5cb778d6a |
| Headers | show |
| Series | arm64: dts: qcom: sc7180: Disable DCC node by default | expand |
Hi, On Wed, Feb 28, 2024 at 5:35 PM Stephen Boyd <swboyd@chromium.org> wrote: > > We don't use this device on Trogdor boards. If we did, it would be > enabled in the sc7180-trogdor.dtsi file. Let's disable this here so that > boards with t he sc7180 SoC can decide to enable or disable this device. s/t he/the/ > Cc: Souradeep Chowdhury <quic_schowdhu@quicinc.com> > Fixes: add74cad7c9d ("arm64: dts: qcom: sc7180: Add Data Capture and Compare(DCC) support node") > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + > 1 file changed, 1 insertion(+) Seems fine to me. I guess the driver never landed, but if/when it lands then it makes sense to just enable the device it for boards that need it. Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Wed, 28 Feb 2024 17:35:01 -0800, Stephen Boyd wrote: > We don't use this device on Trogdor boards. If we did, it would be > enabled in the sc7180-trogdor.dtsi file. Let's disable this here so that > boards with t he sc7180 SoC can decide to enable or disable this device. > > Applied, thanks! [1/1] arm64: dts: qcom: sc7180: Disable DCC node by default commit: 9f618cdce29d7bef10c2f4c8cbf58bc5cb778d6a Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 4dcaa15caef2..f390bf3eccbe 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -2239,6 +2239,7 @@ dma@10a2000 { compatible = "qcom,sc7180-dcc", "qcom,dcc"; reg = <0x0 0x010a2000 0x0 0x1000>, <0x0 0x010ae000 0x0 0x2000>; + status = "disabled"; }; stm@6002000 {
We don't use this device on Trogdor boards. If we did, it would be enabled in the sc7180-trogdor.dtsi file. Let's disable this here so that boards with t he sc7180 SoC can decide to enable or disable this device. Cc: Souradeep Chowdhury <quic_schowdhu@quicinc.com> Fixes: add74cad7c9d ("arm64: dts: qcom: sc7180: Add Data Capture and Compare(DCC) support node") Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 + 1 file changed, 1 insertion(+) base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d