| Message ID | 20240311120859.18489-3-quic_kbajaj@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add devicetree support of USB for QDU/QRU1000 | expand |
On Mon, 11 Mar 2024 at 14:10, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: > > Enable both USB controllers and associated hsphy and qmp phy nodes > on QDU1000 IDP. > > Co-developed-by: Amrit Anand <quic_amrianan@quicinc.com> > Signed-off-by: Amrit Anand <quic_amrianan@quicinc.com> > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > index 89b84fb0f70a..126bc71afd90 100644 > --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > @@ -500,3 +500,27 @@ &tlmm { > &uart7 { > status = "okay"; > }; > + > +&usb_1 { > + status = "okay"; > +}; > + > +&usb_1_dwc3 { > + dr_mode = "peripheral"; Are these ports really peripheral-only? > + maximum-speed = "high-speed"; > +}; > + > +&usb_1_hsphy { > + vdda-pll-supply = <&vreg_l8a_0p91>; > + vdda18-supply = <&vreg_l14a_1p8>; > + vdda33-supply = <&vreg_l2a_2p3>; > + > + status = "okay"; > +}; > + > +&usb_1_qmpphy { > + vdda-phy-supply = <&vreg_l8a_0p91>; > + vdda-pll-supply = <&vreg_l3a_1p2>; > + > + status = "okay"; > +}; > -- > 2.42.0 > >
On 3/11/24 13:14, Dmitry Baryshkov wrote: > On Mon, 11 Mar 2024 at 14:10, Komal Bajaj <quic_kbajaj@quicinc.com> wrote: >> >> Enable both USB controllers and associated hsphy and qmp phy nodes >> on QDU1000 IDP. >> >> Co-developed-by: Amrit Anand <quic_amrianan@quicinc.com> >> Signed-off-by: Amrit Anand <quic_amrianan@quicinc.com> >> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> index 89b84fb0f70a..126bc71afd90 100644 >> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> @@ -500,3 +500,27 @@ &tlmm { >> &uart7 { >> status = "okay"; >> }; >> + >> +&usb_1 { >> + status = "okay"; >> +}; >> + >> +&usb_1_dwc3 { >> + dr_mode = "peripheral"; > > Are these ports really peripheral-only? > >> + maximum-speed = "high-speed"; More importantly, are these ports really HS-only? Konrad
On 3/12/2024 5:34 AM, Konrad Dybcio wrote: > > > On 3/11/24 13:14, Dmitry Baryshkov wrote: >> On Mon, 11 Mar 2024 at 14:10, Komal Bajaj <quic_kbajaj@quicinc.com> >> wrote: >>> >>> Enable both USB controllers and associated hsphy and qmp phy nodes >>> on QDU1000 IDP. >>> >>> Co-developed-by: Amrit Anand <quic_amrianan@quicinc.com> >>> Signed-off-by: Amrit Anand <quic_amrianan@quicinc.com> >>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 24 ++++++++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>> b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>> index 89b84fb0f70a..126bc71afd90 100644 >>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>> @@ -500,3 +500,27 @@ &tlmm { >>> &uart7 { >>> status = "okay"; >>> }; >>> + >>> +&usb_1 { >>> + status = "okay"; >>> +}; >>> + >>> +&usb_1_dwc3 { >>> + dr_mode = "peripheral"; >> >> Are these ports really peripheral-only? This was done for testing. Will add the usb-role-switch role. >> >>> + maximum-speed = "high-speed"; > > More importantly, are these ports really HS-only? Apologies for this, added it for testing purpose only, forgot to remove it. Will remove it. Thanks Komal > > Konrad
diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts index 89b84fb0f70a..126bc71afd90 100644 --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts @@ -500,3 +500,27 @@ &tlmm { &uart7 { status = "okay"; }; + +&usb_1 { + status = "okay"; +}; + +&usb_1_dwc3 { + dr_mode = "peripheral"; + maximum-speed = "high-speed"; +}; + +&usb_1_hsphy { + vdda-pll-supply = <&vreg_l8a_0p91>; + vdda18-supply = <&vreg_l14a_1p8>; + vdda33-supply = <&vreg_l2a_2p3>; + + status = "okay"; +}; + +&usb_1_qmpphy { + vdda-phy-supply = <&vreg_l8a_0p91>; + vdda-pll-supply = <&vreg_l3a_1p2>; + + status = "okay"; +};