| Message ID | 20240314-topic-sm8650-upstream-usb-dt-irq-fix-v1-1-ea8ab2051869@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9f42f7380f6757ce7f0cab5bad56fb350941d32b |
| Headers | show |
| Series | arm64: dts: qcom: sm8650: fix usb interrupts properties | expand |
On 3/14/24 09:53, Neil Armstrong wrote: > Update the usb interrupts properties to fix the following > bindings check errors: > usb@a6f8800: interrupt-names:0: 'pwr_event' was expected > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > usb@a6f8800: interrupt-names:1: 'hs_phy_irq' was expected > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > usb@a6f8800: interrupt-names:2: 'dp_hs_phy_irq' was expected > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > usb@a6f8800: interrupt-names:3: 'dm_hs_phy_irq' was expected > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > usb@a6f8800: interrupt-names: ['hs_phy_irq', 'ss_phy_irq', 'dm_hs_phy_irq', 'dp_hs_phy_irq'] is too short > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > > Cc: Krishna Kurapati <quic_kriskura@quicinc.com> > Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes") > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Thu, 14 Mar 2024 09:53:06 +0100, Neil Armstrong wrote: > Update the usb interrupts properties to fix the following > bindings check errors: > usb@a6f8800: interrupt-names:0: 'pwr_event' was expected > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > usb@a6f8800: interrupt-names:1: 'hs_phy_irq' was expected > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > usb@a6f8800: interrupt-names:2: 'dp_hs_phy_irq' was expected > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > usb@a6f8800: interrupt-names:3: 'dm_hs_phy_irq' was expected > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > usb@a6f8800: interrupt-names: ['hs_phy_irq', 'ss_phy_irq', 'dm_hs_phy_irq', 'dp_hs_phy_irq'] is too short > from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sm8650: fix usb interrupts properties commit: 9f42f7380f6757ce7f0cab5bad56fb350941d32b Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index ba72d8f38420..985ef46a04e1 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -3584,14 +3584,16 @@ usb_1: usb@a6f8800 { compatible = "qcom,sm8650-dwc3", "qcom,dwc3"; reg = <0 0x0a6f8800 0 0x400>; - interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, - <&pdc 17 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended = <&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, + <&pdc 14 IRQ_TYPE_EDGE_RISING>, <&pdc 15 IRQ_TYPE_EDGE_RISING>, - <&pdc 14 IRQ_TYPE_EDGE_RISING>; - interrupt-names = "hs_phy_irq", - "ss_phy_irq", + <&pdc 17 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "pwr_event", + "hs_phy_irq", + "dp_hs_phy_irq", "dm_hs_phy_irq", - "dp_hs_phy_irq"; + "ss_phy_irq"; clocks = <&gcc GCC_CFG_NOC_USB3_PRIM_AXI_CLK>, <&gcc GCC_USB30_PRIM_MASTER_CLK>,
Update the usb interrupts properties to fix the following bindings check errors: usb@a6f8800: interrupt-names:0: 'pwr_event' was expected from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# usb@a6f8800: interrupt-names:1: 'hs_phy_irq' was expected from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# usb@a6f8800: interrupt-names:2: 'dp_hs_phy_irq' was expected from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# usb@a6f8800: interrupt-names:3: 'dm_hs_phy_irq' was expected from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# usb@a6f8800: interrupt-names: ['hs_phy_irq', 'ss_phy_irq', 'dm_hs_phy_irq', 'dp_hs_phy_irq'] is too short from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# Cc: Krishna Kurapati <quic_kriskura@quicinc.com> Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes") Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) --- base-commit: 9bb9b28d0568991b1d63e66fe75afa5f97ad1156 change-id: 20240314-topic-sm8650-upstream-usb-dt-irq-fix-d6bb2fed3fa9 Best regards,