| Message ID | 20240318-fix-some-qcom-kconfig-deps-v1-1-ea0773e3df5a@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0e79d702bf7fac2e63fc32a1b4ff307d71db692f |
| Headers | show |
| Series | clk: qcom: Fix two driver Kconfig dependencies | expand |
On Mon, 18 Mar 2024 at 17:19, Nathan Chancellor <nathan@kernel.org> wrote: > > CONFIG_SC_GCC_8280XP depends on ARM64 but it is selected by > CONFIG_SC_CAMCC_8280XP, which can be selected on ARM, resulting in a > Kconfig warning. > > WARNING: unmet direct dependencies detected for SC_GCC_8280XP > Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n]) > Selected by [y]: > - SC_CAMCC_8280XP [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] > > Add the same dependencies to CONFIG_SC_CAMCC_8280XP to resolve the > warning. > > Fixes: ff93872a9c61 ("clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC") > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/clk/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index 8ab08e7b5b6c..b9ff32cab329 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -474,6 +474,7 @@ config SC_CAMCC_7280 config SC_CAMCC_8280XP tristate "SC8280XP Camera Clock Controller" + depends on ARM64 || COMPILE_TEST select SC_GCC_8280XP help Support for the camera clock controller on Qualcomm Technologies, Inc
CONFIG_SC_GCC_8280XP depends on ARM64 but it is selected by CONFIG_SC_CAMCC_8280XP, which can be selected on ARM, resulting in a Kconfig warning. WARNING: unmet direct dependencies detected for SC_GCC_8280XP Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n]) Selected by [y]: - SC_CAMCC_8280XP [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] Add the same dependencies to CONFIG_SC_CAMCC_8280XP to resolve the warning. Fixes: ff93872a9c61 ("clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC") Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- drivers/clk/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+)