| Message ID | 20240318-msm8974-misc2-v1-1-f71668a2b8cd@z3ntu.xyz (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cad23ffd46e2205582f5a9e9014b3d78ec0256db |
| Headers | show |
| Series | Small fixes for MSM8974 SoC dtsi | expand |
On 18.03.2024 10:24, Luca Weiss wrote: > Add the @0 from reg to the node name, so that both dtc warning and dt > validation failure get resolved. > > arch/arm/boot/dts/qcom/qcom-msm8974.dtsi:106.9-109.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name > > [..]/arch/arm/boot/dts/qcom/qcom-msm8974pro-fairphone-fp2.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]} > from schema $id: http://devicetree.org/schemas/root-node.yaml# > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz> > --- Looks like it's indeed the start of RAM Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi index 5efc38d712cc..00c6526a525d 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi @@ -103,7 +103,7 @@ scm { }; }; - memory { + memory@0 { device_type = "memory"; reg = <0x0 0x0>; };
Add the @0 from reg to the node name, so that both dtc warning and dt validation failure get resolved. arch/arm/boot/dts/qcom/qcom-msm8974.dtsi:106.9-109.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name [..]/arch/arm/boot/dts/qcom/qcom-msm8974pro-fairphone-fp2.dtb: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]} from schema $id: http://devicetree.org/schemas/root-node.yaml# Signed-off-by: Luca Weiss <luca@z3ntu.xyz> --- arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)