From patchwork Fri Mar 29 20:46:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13611042 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 509E53FE20 for ; Fri, 29 Mar 2024 20:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711745433; cv=none; b=KsHyJC/MK6U2Slk9O8/FH7gHxBIfaVcdjlxRMZpZ9tmzq2LVNy9C4jmFP1oIFuaREdDpzqR5aeuq4J1eSeal+qdhF9kA/EtgJSz6lsDKBT0RROEvl2alna4qZFGIb0Jqxg4GM/ld60eK2q83MtSbZgPy0rm5mZiXou/6SvzMSyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711745433; c=relaxed/simple; bh=R8cq5y8opsNuJGie8SiWdm0XAFuqUiR2/EHCWurGSJM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CeuXzt5/AvNPpE3rDNNpzxjM/hMzZEbEHmLvn5ybDeTEWQTNnvk4R7Yk3hxaDUwlbi+k+ha3osqlK7Yh60xQzvC74CHvH4IV2/W8bE3wiboG3tosXjUXiHok4qvHmWEN2oIDt6lqIM6rWh9jANPE6s8WIVo00RpWVQElvUaw4bQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O/efCwrl; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O/efCwrl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711745430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GkZ3VnrUmply6CPeiLZYu4w5doBYEYYwbDbS8GxE4w=; b=O/efCwrl0ZfV/Z7YKZLQB/vrPvDbDpAy31rZHGoJivMIEF2Lto8jDLMdJUgQYQdnfBbAsH sttcGUyO6whT5FLuZ1lrn11JWyRbmqAG7+wGXhbg0vbanaPJ7bY+/PPKp+YT9PU4rcQD22 RX2FRIMuWDTdpJUmA3qCg8E0PeT9e30= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-PQe44VzKNhGAvADEuHqWFQ-1; Fri, 29 Mar 2024 16:50:28 -0400 X-MC-Unique: PQe44VzKNhGAvADEuHqWFQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6986f2dba1eso24297136d6.2 for ; Fri, 29 Mar 2024 13:50:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711745428; x=1712350228; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4GkZ3VnrUmply6CPeiLZYu4w5doBYEYYwbDbS8GxE4w=; b=nhSh7ZvHN+jup+2YlQEEk1p/FX3aDS/gYknyFHHk1uclGJFPlAJxUcuA/1vJIFXU7I lNQmuqL1tobvqNbx9bQ/Fnj49irKz1wYer2oZuKLzrjh9MkNlB0ZD2AOCM2hI2a+UTIK Ce8ElXJK07eRIfVGWFm5P/3i9LyZG9dwiRkLWZlAgGFkFMSmhmmzhRZKSCBHuJuXGMvw +B3FlcWpbctggggEaR6qZ4Ikqerwz3hdUr/IioZ2HKN13myvg8HXM+V769kxtdFRSn6n R2Z538AMkE21kKU9VsIn7h2WKSoI2sGFITdq4lZvWpjvnSHuyxzcvTEBI4KlvB+/NPVI vNnA== X-Forwarded-Encrypted: i=1; AJvYcCWAviGAOe2E+f9rMCqC0TiIS0bMWDyNizvZfvmAyU9GOd7b60oM+gRWd/Txvt407iJKD1s6YMluIMliaXpqy0F+WEVLgnACjmAjuFkkRQ== X-Gm-Message-State: AOJu0YzogkhUnI/G+lKqIVWDsHqyX/HQhDnvxLWQYYhYl4snECZq/7h/ BwjuXWB0wBauX2Oz2menOf+eymxTSTJfmRLFXd4ghbAyTDZHbJDBDarmYOeLHuJc4tjbVgi0BnA 3/RIEGqEy/AcW+orx24jSB2dpo/mPcJZvMHVgdsuXt4vOy496yWNAhnXE42oc2Uw= X-Received: by 2002:a05:6214:1888:b0:698:6faa:74b3 with SMTP id cx8-20020a056214188800b006986faa74b3mr3372483qvb.19.1711745428086; Fri, 29 Mar 2024 13:50:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHodoPhaiAOjuThHpUwwdkVLQEOmEn/gAh7m+wdmNDjPMelrqlfUu/gZ0vzM0RrxHUZOBkGsA== X-Received: by 2002:a05:6214:1888:b0:698:6faa:74b3 with SMTP id cx8-20020a056214188800b006986faa74b3mr3372471qvb.19.1711745427690; Fri, 29 Mar 2024 13:50:27 -0700 (PDT) Received: from x1gen2nano.redhat.com ([2600:1700:1ff0:d0e0::33]) by smtp.gmail.com with ESMTPSA id jz10-20020a0562140e6a00b00698f27c6460sm794271qvb.110.2024.03.29.13.50.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 13:50:27 -0700 (PDT) From: Andrew Halaney To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Janek Kotas , Alim Akhtar , Avri Altman , Bart Van Assche , Can Guo , Anjana Hari Cc: Andrew Halaney , Will Deacon , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH v5 07/11] scsi: ufs: core: Perform read back after writing UTP_TASK_REQ_LIST_BASE_H Date: Fri, 29 Mar 2024 15:46:49 -0500 Message-ID: <20240329-ufs-reset-ensure-effect-before-delay-v5-7-181252004586@redhat.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240329-ufs-reset-ensure-effect-before-delay-v5-0-181252004586@redhat.com> References: <20240329-ufs-reset-ensure-effect-before-delay-v5-0-181252004586@redhat.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mailer: b4 0.13.0 Currently, the UTP_TASK_REQ_LIST_BASE_L/UTP_TASK_REQ_LIST_BASE_H regs are written to and then completed with an mb(). mb() ensure that the write completes, but completion doesn't mean that it isn't stored in a buffer somewhere. The recommendation for ensuring these bits have taken effect on the device is to perform a read back to force it to make it all the way to the device. This is documented in device-io.rst and a talk by Will Deacon on this can be seen over here: https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 Let's do that to ensure the bits hit the device. Because the mb()'s purpose wasn't to add extra ordering (on top of the ordering guaranteed by writel()/readl()), it can safely be removed. Fixes: 88441a8d355d ("scsi: ufs: core: Add hibernation callbacks") Reviewed-by: Manivannan Sadhasivam Reviewed-by: Bart Van Assche Reviewed-by: Can Guo Signed-off-by: Andrew Halaney --- drivers/ufs/core/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index e30fd125988d..a89887878d98 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -10395,7 +10395,7 @@ int ufshcd_system_restore(struct device *dev) * are updated with the latest queue addresses. Only after * updating these addresses, we can queue the new commands. */ - mb(); + ufshcd_readl(hba, REG_UTP_TASK_REQ_LIST_BASE_H); /* Resuming from hibernate, assume that link was OFF */ ufshcd_set_link_off(hba);