From patchwork Fri Mar 29 20:46:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13611043 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DFE048CCD for ; Fri, 29 Mar 2024 20:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711745440; cv=none; b=K8p3SgSDm7VqsOScIq9AhW5nqpeFHIKKTnfo/GETdIxivye7qOKmeQfV6xAn/+bsf/wjimfJxBzSf/+sIKOe1bgSWLIjxDsuLmD9dFQ1ceb5bFxFfJnNicQsIoJaKg2tL/SQ0YBXG7NsVssTv07CSj3pFbw+THFKwuLgcEdyrmc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711745440; c=relaxed/simple; bh=rUiFGJENhkjaL5XQk3rVKmNTCac0phrGlXxO+qQgbyw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OBk/GQs0acBpnEnxPfXbe32uayTlt1pcZhpo0JXJoxMG8gIZapFNqNh8i+ORBzJ5JxohXVrFYVJVZkvIjlfbo6FYIZry2vSka6fT2ut+eSQc8bkSxpK65DivsURI4MN5Je/E9ihjTquQ7I29R+T/+mvTe/GrlM7SH8eaq3n+Ec8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SNnb0Btd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SNnb0Btd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711745438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kfliicv5toOd2B87oyO1cEhsCWrclX7x2KOA+OKHojY=; b=SNnb0BtdMAiu8JFtG5ieLerpiuw/aRcaHlKtwg5pZFabcwAUXbzMpq/dCI9YLDzi23sHhP KVHr9RRN1DWZdAYKEa/nnP4t/CMf1u0BOI7C/Tj73rF81k2eMNLiD8ERdK1Oepy2kn4TDS McijsfhoP7QiAkdrjaz39g6xtbg7rqw= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-300-y6WVgNyANhuJ_ShBm2S6eQ-1; Fri, 29 Mar 2024 16:50:36 -0400 X-MC-Unique: y6WVgNyANhuJ_ShBm2S6eQ-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-696a266542cso20037966d6.0 for ; Fri, 29 Mar 2024 13:50:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711745433; x=1712350233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kfliicv5toOd2B87oyO1cEhsCWrclX7x2KOA+OKHojY=; b=lwQbgEeqcK/mHIyvbzLtRo9Ob2/RCXf1LiN78kuAlq9iWDdmxhmudpR8V/stdIV63M dc9onwPzaAPl+cIrTO5n55pRi6Ez9FyriSFZVvRqTuOzkujEoY52GDfZULT/SqmR4VAa /luKHZltEiyeOJm4g01Fn/JeUt9u/pxyhgnMxzqze80A9TgtF1qVhSKjbQDqUp3ew5k2 U8qupZKhBzHZs6bnNn4kTKhsLFrCfBG1BOo1Vi0cC/Dgm3rSUJd2MCkNnVvHK+X9MR8d Tu4WcobaCxSY/AE/mi3KPF1wbMW/FntfTwc2c2VGBQCSSzDCPWLNRwHwbwOPTcJdYMTX D70Q== X-Forwarded-Encrypted: i=1; AJvYcCUf6FtTexcxZ6qPVToJHey38hCMTjJBnaJX+SBpP5RDaQjvKRVSPs3WSk/9slbQ/8u6ynHtxABim2XTt1/OyWu/ndCQ/pke+gIBiUlAZQ== X-Gm-Message-State: AOJu0YwoZ2v0EPBi9bq8CXyi2Ctv31iu8E75Ow3VbAxBomGJNhpPddPo vW7rEaRyrxE6EsRGFFKnL80xJgsfhPdkm59JhH5UaCZ7D9NzTcosrxO1XAlrS1N74VgVlun5x2e Vg2jzErRmLhYC3xX2RjcdR+Pg3/HpWexKJ+Ozd/Qu1jR+paXnJ/znuwqxy5oMSGo= X-Received: by 2002:a05:6214:190a:b0:696:b095:c429 with SMTP id er10-20020a056214190a00b00696b095c429mr3119253qvb.40.1711745433043; Fri, 29 Mar 2024 13:50:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSRd/5i8QlyLSkwg85Jxr+u352RMnwF3m/7r26iSWU00W9M/Q4Hw8RMOt9vf05jAbg6L8gpQ== X-Received: by 2002:a05:6214:190a:b0:696:b095:c429 with SMTP id er10-20020a056214190a00b00696b095c429mr3119243qvb.40.1711745432697; Fri, 29 Mar 2024 13:50:32 -0700 (PDT) Received: from x1gen2nano.redhat.com ([2600:1700:1ff0:d0e0::33]) by smtp.gmail.com with ESMTPSA id jz10-20020a0562140e6a00b00698f27c6460sm794271qvb.110.2024.03.29.13.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 13:50:31 -0700 (PDT) From: Andrew Halaney To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Janek Kotas , Alim Akhtar , Avri Altman , Bart Van Assche , Can Guo , Anjana Hari Cc: Andrew Halaney , Will Deacon , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam Subject: [PATCH v5 08/11] scsi: ufs: core: Perform read back after disabling interrupts Date: Fri, 29 Mar 2024 15:46:50 -0500 Message-ID: <20240329-ufs-reset-ensure-effect-before-delay-v5-8-181252004586@redhat.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240329-ufs-reset-ensure-effect-before-delay-v5-0-181252004586@redhat.com> References: <20240329-ufs-reset-ensure-effect-before-delay-v5-0-181252004586@redhat.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mailer: b4 0.13.0 Currently, interrupts are cleared and disabled prior to registering the interrupt. An mb() is used to complete the clear/disable writes before the interrupt is registered. mb() ensure that the write completes, but completion doesn't mean that it isn't stored in a buffer somewhere. The recommendation for ensuring these bits have taken effect on the device is to perform a read back to force it to make it all the way to the device. This is documented in device-io.rst and a talk by Will Deacon on this can be seen over here: https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 Let's do that to ensure these bits hit the device. Because the mb()'s purpose wasn't to add extra ordering (on top of the ordering guaranteed by writel()/readl()), it can safely be removed. Fixes: 199ef13cac7d ("scsi: ufs: avoid spurious UFS host controller interrupts") Reviewed-by: Manivannan Sadhasivam Reviewed-by: Bart Van Assche Reviewed-by: Can Guo Signed-off-by: Andrew Halaney --- drivers/ufs/core/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index a89887878d98..268fcfebd7bd 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -10616,7 +10616,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq) * Make sure that UFS interrupts are disabled and any pending interrupt * status is cleared before registering UFS interrupt handler. */ - mb(); + ufshcd_readl(hba, REG_INTERRUPT_ENABLE); /* IRQ registration */ err = devm_request_irq(dev, irq, ufshcd_intr, IRQF_SHARED, UFSHCD, hba);