| Message ID | 20240330091311.6224-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [v2,1/2] arm64: dts: qcom: pm6150: correct Type-C compatible | expand |
On 30.03.2024 10:13 AM, Krzysztof Kozlowski wrote: > The first part of the compatible of Type-C node misses ending quote, > thus we have one long compatible consisting of two compatible strings > leading to dtbs_check warnings: > > sc7180-acer-aspire1.dtb: pmic@0: typec@1500:compatible: 'oneOf' conditional failed, one must be fixed > sc7180-acer-aspire1.dtb: typec@1500: compatible:0: 'qcom,pm6150-typec,\n qcom,pm8150b-typec' does not match '^[a-zA-Z0-9][a-zA-Z0-9,+\\-._/]+$' > > Reported-by: Rob Herring <robh@kernel.org> > Fixes: f81c2f01cad6 ("arm64: dts: qcom: pm6150: define USB-C related blocks") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- LOL! Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Sat, 30 Mar 2024 10:13:10 +0100, Krzysztof Kozlowski wrote: > The first part of the compatible of Type-C node misses ending quote, > thus we have one long compatible consisting of two compatible strings > leading to dtbs_check warnings: > > sc7180-acer-aspire1.dtb: pmic@0: typec@1500:compatible: 'oneOf' conditional failed, one must be fixed > sc7180-acer-aspire1.dtb: typec@1500: compatible:0: 'qcom,pm6150-typec,\n qcom,pm8150b-typec' does not match '^[a-zA-Z0-9][a-zA-Z0-9,+\\-._/]+$' > > [...] Applied, thanks! [2/2] arm64: dts: qcom: pm6150: correct USB VBUS regulator compatible commit: 0ea3e1d6f31d8aea72d0d0b53919c585a12a593b Best regards,
diff --git a/arch/arm64/boot/dts/qcom/pm6150.dtsi b/arch/arm64/boot/dts/qcom/pm6150.dtsi index 11158c2bd524..b20a639cddf3 100644 --- a/arch/arm64/boot/dts/qcom/pm6150.dtsi +++ b/arch/arm64/boot/dts/qcom/pm6150.dtsi @@ -71,8 +71,8 @@ pm6150_vbus: usb-vbus-regulator@1100 { }; pm6150_typec: typec@1500 { - compatible = "qcom,pm6150-typec, - qcom,pm8150b-typec"; + compatible = "qcom,pm6150-typec", + "qcom,pm8150b-typec"; reg = <0x1500>, <0x1700>; interrupts = <0x0 0x15 0x00 IRQ_TYPE_EDGE_RISING>, <0x0 0x15 0x01 IRQ_TYPE_EDGE_BOTH>,
The first part of the compatible of Type-C node misses ending quote, thus we have one long compatible consisting of two compatible strings leading to dtbs_check warnings: sc7180-acer-aspire1.dtb: pmic@0: typec@1500:compatible: 'oneOf' conditional failed, one must be fixed sc7180-acer-aspire1.dtb: typec@1500: compatible:0: 'qcom,pm6150-typec,\n qcom,pm8150b-typec' does not match '^[a-zA-Z0-9][a-zA-Z0-9,+\\-._/]+$' Reported-by: Rob Herring <robh@kernel.org> Fixes: f81c2f01cad6 ("arm64: dts: qcom: pm6150: define USB-C related blocks") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes in v2: 1. Correct warning msg --- arch/arm64/boot/dts/qcom/pm6150.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)