| Message ID | 20240410164045.233198-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | soc: qcom: fix module autoloading | expand |
On 4/10/24 18:40, Krzysztof Kozlowski wrote: > Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded > based on the alias from of_device_id table. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- These were omitted intentionally, as these are both debug drivers. Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer Konrad
On Wed, Apr 10, 2024 at 07:53:32PM +0200, Konrad Dybcio wrote: > > > On 4/10/24 18:40, Krzysztof Kozlowski wrote: > > Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded > > based on the alias from of_device_id table. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > These were omitted intentionally, as these are both debug drivers. > Makes sense to me, could we have a comment added that clarifies this intention? > Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer > Not sure if that is necessary, and IMO it wouldn't convey that MODULE_DEVICE_TABLE() was omitted intentionally. Regards, Bjorn
On 10/04/2024 20:11, Bjorn Andersson wrote: > On Wed, Apr 10, 2024 at 07:53:32PM +0200, Konrad Dybcio wrote: >> >> >> On 4/10/24 18:40, Krzysztof Kozlowski wrote: >>> Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded >>> based on the alias from of_device_id table. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >>> --- >> >> These were omitted intentionally, as these are both debug drivers. >> > > Makes sense to me, could we have a comment added that clarifies this > intention? > >> Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer >> > > Not sure if that is necessary, and IMO it wouldn't convey that > MODULE_DEVICE_TABLE() was omitted intentionally. I think this deserves a comment, so no one will be doing my same again (it's part of bigger effort). Best regards, Krzysztof
diff --git a/drivers/soc/qcom/pmic_pdcharger_ulog.c b/drivers/soc/qcom/pmic_pdcharger_ulog.c index 238cd38589dc..5f9ea3fe6d6d 100644 --- a/drivers/soc/qcom/pmic_pdcharger_ulog.c +++ b/drivers/soc/qcom/pmic_pdcharger_ulog.c @@ -150,6 +150,7 @@ static const struct rpmsg_device_id pmic_pdcharger_ulog_rpmsg_id_match[] = { { "PMIC_LOGS_ADSP_APPS" }, {} }; +MODULE_DEVICE_TABLE(rpmsg, pmic_pdcharger_ulog_rpmsg_id_match); static struct rpmsg_driver pmic_pdcharger_ulog_rpmsg_driver = { .probe = pmic_pdcharger_ulog_rpmsg_probe, diff --git a/drivers/soc/qcom/rpm_master_stats.c b/drivers/soc/qcom/rpm_master_stats.c index 9ca13bcf67d3..c5745e20e736 100644 --- a/drivers/soc/qcom/rpm_master_stats.c +++ b/drivers/soc/qcom/rpm_master_stats.c @@ -148,6 +148,7 @@ static const struct of_device_id rpm_master_table[] = { { .compatible = "qcom,rpm-master-stats" }, { }, }; +MODULE_DEVICE_TABLE(of, rpm_master_table); static struct platform_driver master_stats_driver = { .probe = master_stats_probe,
Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/soc/qcom/pmic_pdcharger_ulog.c | 1 + drivers/soc/qcom/rpm_master_stats.c | 1 + 2 files changed, 2 insertions(+)