| Message ID | 20240415-fix-cocci-v1-4-477afb23728b@chromium.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: Fix coccinelle warning/errors | expand |
Quoting Ricardo Ribalda (2024-04-15 20:34:21) > It makes the code slightly more clear and makes cocci incredibly happy: > > drivers/media/usb/uvc/uvc_ctrl.c:839:22-23: WARNING opportunity for max() > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/usb/uvc/uvc_ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c > index a4a987913430..4b685f883e4d 100644 > --- a/drivers/media/usb/uvc/uvc_ctrl.c > +++ b/drivers/media/usb/uvc/uvc_ctrl.c > @@ -836,7 +836,7 @@ static s32 uvc_get_le_value(struct uvc_control_mapping *mapping, > while (1) { > u8 byte = *data & mask; > value |= offset > 0 ? (byte >> offset) : (byte << (-offset)); > - bits -= 8 - (offset > 0 ? offset : 0); > + bits -= 8 - max(offset, 0); This looks semantically the same to me so: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > if (bits <= 0) > break; > > > -- > 2.44.0.683.g7961c838ac-goog >
On (24/04/15 19:34), Ricardo Ribalda wrote: > It makes the code slightly more clear and makes cocci incredibly happy: > > drivers/media/usb/uvc/uvc_ctrl.c:839:22-23: WARNING opportunity for max() > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
On Mon, Apr 15, 2024 at 07:34:21PM +0000, Ricardo Ribalda wrote: > It makes the code slightly more clear and makes cocci incredibly happy: > > drivers/media/usb/uvc/uvc_ctrl.c:839:22-23: WARNING opportunity for max() > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/usb/uvc/uvc_ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c > index a4a987913430..4b685f883e4d 100644 > --- a/drivers/media/usb/uvc/uvc_ctrl.c > +++ b/drivers/media/usb/uvc/uvc_ctrl.c > @@ -836,7 +836,7 @@ static s32 uvc_get_le_value(struct uvc_control_mapping *mapping, > while (1) { > u8 byte = *data & mask; > value |= offset > 0 ? (byte >> offset) : (byte << (-offset)); > - bits -= 8 - (offset > 0 ? offset : 0); > + bits -= 8 - max(offset, 0); I don't think this really improve readability. > if (bits <= 0) > break; >
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index a4a987913430..4b685f883e4d 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -836,7 +836,7 @@ static s32 uvc_get_le_value(struct uvc_control_mapping *mapping, while (1) { u8 byte = *data & mask; value |= offset > 0 ? (byte >> offset) : (byte << (-offset)); - bits -= 8 - (offset > 0 ? offset : 0); + bits -= 8 - max(offset, 0); if (bits <= 0) break;
It makes the code slightly more clear and makes cocci incredibly happy: drivers/media/usb/uvc/uvc_ctrl.c:839:22-23: WARNING opportunity for max() Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- drivers/media/usb/uvc/uvc_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)