| Message ID | 20240418-x1e80100-dts-fix-mdss-dp3-v1-1-9f8420e395d4@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: x1e80100: Fix the data-lanes and link-frequencies | expand |
On 18.04.2024 12:22 PM, Abel Vesa wrote: > The link-frequences belong in mdss_dp3_out. Display is broken because of > this. Drop them from mdss_dp3_in. > > Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes") > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index f5a3b39ae70e..0642b5e88639 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -4096,7 +4096,6 @@ port@0 { > mdss_dp3_in: endpoint { > remote-endpoint = <&mdss_intf5_out>; > > - link-frequencies = /bits/ 64 <8100000000>; Could you also remove the stray blank line above? Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Thu, Apr 18, 2024 at 01:22:18PM +0300, Abel Vesa wrote: > The link-frequences belong in mdss_dp3_out. Display is broken because of > this. Drop them from mdss_dp3_in. > Why is display broken because you have this property in the wrong node? Isn't it broken because you don't have it in &mdss_dp3_out and this is just a cleanup of an invalid property? Perhaps that's what you're trying to say? Would be nice to have that clarified. Regards, Bjorn > Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes") > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > index f5a3b39ae70e..0642b5e88639 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > @@ -4096,7 +4096,6 @@ port@0 { > mdss_dp3_in: endpoint { > remote-endpoint = <&mdss_intf5_out>; > > - link-frequencies = /bits/ 64 <8100000000>; > }; > }; > > > -- > 2.34.1 >
On 24-04-18 08:57:37, Bjorn Andersson wrote: > On Thu, Apr 18, 2024 at 01:22:18PM +0300, Abel Vesa wrote: > > The link-frequences belong in mdss_dp3_out. Display is broken because of > > this. Drop them from mdss_dp3_in. > > > > Why is display broken because you have this property in the wrong node? > Isn't it broken because you don't have it in &mdss_dp3_out and this is > just a cleanup of an invalid property? > > Perhaps that's what you're trying to say? Would be nice to have that > clarified. Will drop the "Display is broken because of this." part. Thanks. > > Regards, > Bjorn > > > Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes") > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > index f5a3b39ae70e..0642b5e88639 100644 > > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi > > @@ -4096,7 +4096,6 @@ port@0 { > > mdss_dp3_in: endpoint { > > remote-endpoint = <&mdss_intf5_out>; > > > > - link-frequencies = /bits/ 64 <8100000000>; > > }; > > }; > > > > > > -- > > 2.34.1 > >
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi index f5a3b39ae70e..0642b5e88639 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi @@ -4096,7 +4096,6 @@ port@0 { mdss_dp3_in: endpoint { remote-endpoint = <&mdss_intf5_out>; - link-frequencies = /bits/ 64 <8100000000>; }; };
The link-frequences belong in mdss_dp3_out. Display is broken because of this. Drop them from mdss_dp3_in. Fixes: 1940c25eaa63 ("arm64: dts: qcom: x1e80100: Add display nodes") Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1 - 1 file changed, 1 deletion(-)