[v2] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent

Commit Message

Sagar Cheluvegowda May 1, 2024, 3:45 a.m. UTC

Ethernet devices are cache coherent, mark it as such in the dtsi.
Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")

Signed-off-by: Sagar Cheluvegowda <[e-mail]>
---
Changes in v2:
Remove internal change-id from commit message
- Link to v1: https://lore.kernel.org/r/[e-mail]
---
 arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++
 1 file changed, 2 insertions(+)


---
base-commit: a93289b830ce783955b22fbe5d1274a464c05acf
change-id: 20240425-mark_ethernet_devices_dma_coherent-6c6154b84165

Best regards,

Comments

Trilok Soni May 1, 2024, 4:58 a.m. UTC | #1

On 4/30/2024 8:45 PM, Sagar Cheluvegowda wrote:
> Ethernet devices are cache coherent, mark it as such in the dtsi.
> Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
> Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")
> 
> Signed-off-by: Sagar Cheluvegowda <[e-mail]>
> ---
> Changes in v2:
> Remove internal change-id from commit message
> - Link to v1: https://lore.kernel.org/r/[e-mail]

I haven't seen this style of keeping the changelog at this place. It should

> ---

^^^ start here

>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>

Dmitry Baryshkov May 1, 2024, 5:04 a.m. UTC | #2

On Wed, 1 May 2024 at 07:58, Trilok Soni <[e-mail]> wrote:
>
> On 4/30/2024 8:45 PM, Sagar Cheluvegowda wrote:
> > Ethernet devices are cache coherent, mark it as such in the dtsi.
> > Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
> > Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")
> >
> > Signed-off-by: Sagar Cheluvegowda <[e-mail]>
> > ---
> > Changes in v2:
> > Remove internal change-id from commit message
> > - Link to v1: https://lore.kernel.org/r/[e-mail]
>
> I haven't seen this style of keeping the changelog at this place. It should

This is fine, b4 tool inserts it this way. The changelog will be
ignored by the git-am tools.

>
> > ---
>
> ^^^ start here
>
> >  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
>
> --
> ---Trilok Soni
>
>

Andrew Halaney May 1, 2024, 3:17 p.m. UTC | #3

On Tue, Apr 30, 2024 at 08:45:18PM -0700, Sagar Cheluvegowda wrote:
> Ethernet devices are cache coherent, mark it as such in the dtsi.
> Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
> Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")
> 
> Signed-off-by: Sagar Cheluvegowda <[e-mail]>

Nit: Fixes: and Signed-off-by: should be grouped together.. i.e.:

    Ethernet devices are cache coherent, mark it as such in the dtsi.

    Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
    Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")
    Signed-off-by: Sagar Cheluvegowda <[e-mail]>

> ---
> Changes in v2:
> Remove internal change-id from commit message
> - Link to v1: https://lore.kernel.org/r/[e-mail]
> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 231cea1f0fa8..5ab4ca978837 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -2504,6 +2504,7 @@ ethernet1: ethernet@23000000 {
>  			phy-names = "serdes";
>  
>  			iommus = <&apps_smmu 0x140 0xf>;
> +			dma-coherent;
>  
>  			snps,tso;
>  			snps,pbl = <32>;
> @@ -2538,6 +2539,7 @@ ethernet0: ethernet@23040000 {
>  			phy-names = "serdes";
>  
>  			iommus = <&apps_smmu 0x120 0xf>;
> +			dma-coherent;

Does the schema need updating then?

    (dtb-checker) ahalaney@x1gen2nano ~/git/linux-next (git)-[b4970433daf5] % make CC=clang ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y DT_SCHEMA_FILES=/net/qcom,ethqos.yaml qcom/sa8775p-ride.dtb
      UPD     include/config/kernel.release
      DTC_CHK arch/arm64/boot/dts/qcom/sa8775p-ride.dtb
    /home/ahalaney/git/linux-next/arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: ethernet@23000000: Unevaluated properties are not allowed ('dma-coherent' was unexpected)
	    from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml#
    /home/ahalaney/git/linux-next/arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: ethernet@23040000: Unevaluated properties are not allowed ('dma-coherent' was unexpected)
	    from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml#

You can use eb15bd5c2a69 ("dt-bindings: dmaengine: qcom: gpi: Allow dma-coherent")
for inspiration for crafting that patch and adding it into the beginning
of this series.

>  
>  			snps,tso;
>  			snps,pbl = <32>;
> 
> ---
> base-commit: a93289b830ce783955b22fbe5d1274a464c05acf
> change-id: 20240425-mark_ethernet_devices_dma_coherent-6c6154b84165

It seems you're using b4 (yay! good choice). I noticed the To/Cc list
here seems small. b4 prep --auto-to-cc should basically use
get_maintainers.pl and include the relevant folks. You can add on to it
from there with b4 prep --edit-cover. Typically if someone gives you a comment
on a patch its a good idea to Cc them on the next version (in case they weren't
on the prior).

> 
> Best regards,
> -- 
> Sagar Cheluvegowda <[e-mail]>
> 
>

Patch

diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 231cea1f0fa8..5ab4ca978837 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -2504,6 +2504,7 @@  ethernet1: ethernet@23000000 {
 			phy-names = "serdes";
 
 			iommus = <&apps_smmu 0x140 0xf>;
+			dma-coherent;
 
 			snps,tso;
 			snps,pbl = <32>;
@@ -2538,6 +2539,7 @@  ethernet0: ethernet@23040000 {
 			phy-names = "serdes";
 
 			iommus = <&apps_smmu 0x120 0xf>;
+			dma-coherent;
 
 			snps,tso;
 			snps,pbl = <32>;