| Message ID | 20240507144821.12275-4-johan+linaro@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | HID/arm64: dts: qcom: sc8280xp-x13s: fix touchscreen power on | expand |
On 07/05/2024 16:48, Johan Hovold wrote: > When the power supply is shared with other peripherals the reset line > can be wired in such a way that it can remain deasserted regardless of > whether the supply is on or not. > > This is important as it can be used to avoid holding the controller in > reset for extended periods of time when it remains powered, something > which can lead to increased power consumption. Leaving reset deasserted > also avoids leaking current through the reset circuitry pull-up > resistors. > > Add a new 'no-reset-on-power-off' devicetree property which can be used > by the OS to determine when reset needs to be asserted on power down. > > Note that this property can also be used when the supply cannot be > turned off by the OS at all. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, May 7, 2024 at 4:48 PM Johan Hovold <johan+linaro@kernel.org> wrote: > When the power supply is shared with other peripherals the reset line > can be wired in such a way that it can remain deasserted regardless of > whether the supply is on or not. > > This is important as it can be used to avoid holding the controller in > reset for extended periods of time when it remains powered, something > which can lead to increased power consumption. Leaving reset deasserted > also avoids leaking current through the reset circuitry pull-up > resistors. > > Add a new 'no-reset-on-power-off' devicetree property which can be used > by the OS to determine when reset needs to be asserted on power down. > > Note that this property can also be used when the supply cannot be > turned off by the OS at all. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml index be84f7ed0abc..a62916d07a08 100644 --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml @@ -36,6 +36,12 @@ properties: reset-gpios: description: Reset GPIO; not all touchscreens using eKTH6915 hook this up. + no-reset-on-power-off: + type: boolean + description: + Reset line is wired so that it can (and should) be left deasserted when + the power supply is off. + vcc33-supply: description: The 3.3V supply to the touchscreen.
When the power supply is shared with other peripherals the reset line can be wired in such a way that it can remain deasserted regardless of whether the supply is on or not. This is important as it can be used to avoid holding the controller in reset for extended periods of time when it remains powered, something which can lead to increased power consumption. Leaving reset deasserted also avoids leaking current through the reset circuitry pull-up resistors. Add a new 'no-reset-on-power-off' devicetree property which can be used by the OS to determine when reset needs to be asserted on power down. Note that this property can also be used when the supply cannot be turned off by the OS at all. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 6 ++++++ 1 file changed, 6 insertions(+)