diff mbox series

[v2] bus: mhi: host: Add Foxconn SDX72 related support

Message ID 20240520070633.308913-1-slark_xiao@163.com (mailing list archive)
State Superseded
Headers show
Series [v2] bus: mhi: host: Add Foxconn SDX72 related support | expand

Commit Message

Slark Xiao May 20, 2024, 7:06 a.m. UTC 
Align with Qcom SDX72, add ready timeout item for Foxconn SDX72.
And also, add firehose support since SDX72.

Signed-off-by: Slark Xiao <slark_xiao@163.com>
---
v2: (1). Update the edl file path and name (2). Set SDX72 support
trigger edl mode by default
---
 drivers/bus/mhi/host/pci_generic.c | 32 ++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

Comments

Slark Xiao May 31, 2024, 7:37 a.m. UTC | #1 
Hi Mani,
Do you miss this commit?
I didn't get any response yet. 

At 2024-05-20 15:06:33, "Slark Xiao" <slark_xiao@163.com> wrote:
>Align with Qcom SDX72, add ready timeout item for Foxconn SDX72.
>And also, add firehose support since SDX72.
>
>Signed-off-by: Slark Xiao <slark_xiao@163.com>
>---
>v2: (1). Update the edl file path and name (2). Set SDX72 support
>trigger edl mode by default
>---
> drivers/bus/mhi/host/pci_generic.c | 32 ++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
>diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
>index 08844ee79654..0b483c7c76a1 100644
>--- a/drivers/bus/mhi/host/pci_generic.c
>+++ b/drivers/bus/mhi/host/pci_generic.c
>@@ -399,6 +399,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
> 	MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> 	MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> 	MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
>+	MHI_CHANNEL_CONFIG_UL_FP(34, "FIREHOSE", 32, 0),
>+	MHI_CHANNEL_CONFIG_DL_FP(35, "FIREHOSE", 32, 0),
> 	MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> 	MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> };
>@@ -419,6 +421,16 @@ static const struct mhi_controller_config modem_foxconn_sdx55_config = {
> 	.event_cfg = mhi_foxconn_sdx55_events,
> };
> 
>+static const struct mhi_controller_config modem_foxconn_sdx72_config = {
>+	.max_channels = 128,
>+	.timeout_ms = 20000,
>+	.ready_timeout_ms = 50000,
>+	.num_channels = ARRAY_SIZE(mhi_foxconn_sdx55_channels),
>+	.ch_cfg = mhi_foxconn_sdx55_channels,
>+	.num_events = ARRAY_SIZE(mhi_foxconn_sdx55_events),
>+	.event_cfg = mhi_foxconn_sdx55_events,
>+};
>+
> static const struct mhi_pci_dev_info mhi_foxconn_sdx24_info = {
> 	.name = "foxconn-sdx24",
> 	.config = &modem_foxconn_sdx55_config,
>@@ -448,6 +460,17 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx65_info = {
> 	.sideband_wake = false,
> };
> 
>+static const struct mhi_pci_dev_info mhi_foxconn_sdx72_info = {
>+	.name = "foxconn-sdx72",
>+	.edl = "fox/sdx72m/edl.mbn",
>+	.edl_trigger = true,
>+	.config = &modem_foxconn_sdx72_config,
>+	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>+	.dma_data_width = 32,
>+	.mru_default = 32768,
>+	.sideband_wake = false,
>+};
>+
> static const struct mhi_channel_config mhi_mv3x_channels[] = {
> 	MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 64, 0),
> 	MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 64, 0),
>@@ -680,6 +703,15 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> 	/* DW5932e (sdx62), Non-eSIM */
> 	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0f9),
> 		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx65_info },
>+	/* T99W515 (sdx72) */
>+	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe118),
>+		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx72_info },
>+	/* DW5934e(sdx72), With eSIM */
>+	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe11d),
>+		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx72_info },
>+	/* DW5934e(sdx72), Non-eSIM */
>+	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe11e),
>+		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx72_info },
> 	/* MV31-W (Cinterion) */
> 	{ PCI_DEVICE(PCI_VENDOR_ID_THALES, 0x00b3),
> 		.driver_data = (kernel_ulong_t) &mhi_mv31_info },
>-- 
>2.25.1
Manivannan Sadhasivam June 5, 2024, 5:54 a.m. UTC | #2 
On Mon, May 20, 2024 at 03:06:33PM +0800, Slark Xiao wrote:
> Align with Qcom SDX72, add ready timeout item for Foxconn SDX72.
> And also, add firehose support since SDX72.
> 
> Signed-off-by: Slark Xiao <slark_xiao@163.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
> v2: (1). Update the edl file path and name (2). Set SDX72 support
> trigger edl mode by default
> ---
>  drivers/bus/mhi/host/pci_generic.c | 32 ++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 08844ee79654..0b483c7c76a1 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -399,6 +399,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
>  	MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
>  	MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
>  	MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> +	MHI_CHANNEL_CONFIG_UL_FP(34, "FIREHOSE", 32, 0),
> +	MHI_CHANNEL_CONFIG_DL_FP(35, "FIREHOSE", 32, 0),
>  	MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
>  	MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>  };
> @@ -419,6 +421,16 @@ static const struct mhi_controller_config modem_foxconn_sdx55_config = {
>  	.event_cfg = mhi_foxconn_sdx55_events,
>  };
>  
> +static const struct mhi_controller_config modem_foxconn_sdx72_config = {
> +	.max_channels = 128,
> +	.timeout_ms = 20000,
> +	.ready_timeout_ms = 50000,
> +	.num_channels = ARRAY_SIZE(mhi_foxconn_sdx55_channels),
> +	.ch_cfg = mhi_foxconn_sdx55_channels,
> +	.num_events = ARRAY_SIZE(mhi_foxconn_sdx55_events),
> +	.event_cfg = mhi_foxconn_sdx55_events,
> +};
> +
>  static const struct mhi_pci_dev_info mhi_foxconn_sdx24_info = {
>  	.name = "foxconn-sdx24",
>  	.config = &modem_foxconn_sdx55_config,
> @@ -448,6 +460,17 @@ static const struct mhi_pci_dev_info mhi_foxconn_sdx65_info = {
>  	.sideband_wake = false,
>  };
>  
> +static const struct mhi_pci_dev_info mhi_foxconn_sdx72_info = {
> +	.name = "foxconn-sdx72",
> +	.edl = "fox/sdx72m/edl.mbn",
> +	.edl_trigger = true,
> +	.config = &modem_foxconn_sdx72_config,
> +	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> +	.dma_data_width = 32,
> +	.mru_default = 32768,
> +	.sideband_wake = false,
> +};
> +
>  static const struct mhi_channel_config mhi_mv3x_channels[] = {
>  	MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 64, 0),
>  	MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 64, 0),
> @@ -680,6 +703,15 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>  	/* DW5932e (sdx62), Non-eSIM */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0f9),
>  		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx65_info },
> +	/* T99W515 (sdx72) */
> +	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe118),
> +		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx72_info },
> +	/* DW5934e(sdx72), With eSIM */
> +	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe11d),
> +		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx72_info },
> +	/* DW5934e(sdx72), Non-eSIM */
> +	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe11e),
> +		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx72_info },
>  	/* MV31-W (Cinterion) */
>  	{ PCI_DEVICE(PCI_VENDOR_ID_THALES, 0x00b3),
>  		.driver_data = (kernel_ulong_t) &mhi_mv31_info },
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 08844ee79654..0b483c7c76a1 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -399,6 +399,8 @@  static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
 	MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
 	MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
 	MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
+	MHI_CHANNEL_CONFIG_UL_FP(34, "FIREHOSE", 32, 0),
+	MHI_CHANNEL_CONFIG_DL_FP(35, "FIREHOSE", 32, 0),
 	MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
 	MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
 };
@@ -419,6 +421,16 @@  static const struct mhi_controller_config modem_foxconn_sdx55_config = {
 	.event_cfg = mhi_foxconn_sdx55_events,
 };
 
+static const struct mhi_controller_config modem_foxconn_sdx72_config = {
+	.max_channels = 128,
+	.timeout_ms = 20000,
+	.ready_timeout_ms = 50000,
+	.num_channels = ARRAY_SIZE(mhi_foxconn_sdx55_channels),
+	.ch_cfg = mhi_foxconn_sdx55_channels,
+	.num_events = ARRAY_SIZE(mhi_foxconn_sdx55_events),
+	.event_cfg = mhi_foxconn_sdx55_events,
+};
+
 static const struct mhi_pci_dev_info mhi_foxconn_sdx24_info = {
 	.name = "foxconn-sdx24",
 	.config = &modem_foxconn_sdx55_config,
@@ -448,6 +460,17 @@  static const struct mhi_pci_dev_info mhi_foxconn_sdx65_info = {
 	.sideband_wake = false,
 };
 
+static const struct mhi_pci_dev_info mhi_foxconn_sdx72_info = {
+	.name = "foxconn-sdx72",
+	.edl = "fox/sdx72m/edl.mbn",
+	.edl_trigger = true,
+	.config = &modem_foxconn_sdx72_config,
+	.bar_num = MHI_PCI_DEFAULT_BAR_NUM,
+	.dma_data_width = 32,
+	.mru_default = 32768,
+	.sideband_wake = false,
+};
+
 static const struct mhi_channel_config mhi_mv3x_channels[] = {
 	MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 64, 0),
 	MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 64, 0),
@@ -680,6 +703,15 @@  static const struct pci_device_id mhi_pci_id_table[] = {
 	/* DW5932e (sdx62), Non-eSIM */
 	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0f9),
 		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx65_info },
+	/* T99W515 (sdx72) */
+	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe118),
+		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx72_info },
+	/* DW5934e(sdx72), With eSIM */
+	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe11d),
+		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx72_info },
+	/* DW5934e(sdx72), Non-eSIM */
+	{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe11e),
+		.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx72_info },
 	/* MV31-W (Cinterion) */
 	{ PCI_DEVICE(PCI_VENDOR_ID_THALES, 0x00b3),
 		.driver_data = (kernel_ulong_t) &mhi_mv31_info },