diff mbox series

[v2,1/4] dt-bindings: i2c: qcom-cci: Document sm8550 compatible

Message ID 20240612215835.1149199-2-vladimir.zapolskiy@linaro.org (mailing list archive)
State Not Applicable
Headers show
Series arm64: dts: qcom: add description of CCI controllers for sm8550 and sm8650 | expand

Commit Message

Vladimir Zapolskiy June 12, 2024, 9:58 p.m. UTC
Add sm8550 compatible consistent with CAMSS CCI interfaces, the list of
clocks is reduced by removing "slow_ahb_src" clock, which is derived
from "cpas_ahb" clock.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
 .../devicetree/bindings/i2c/qcom,i2c-cci.yaml  | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Krzysztof Kozlowski June 13, 2024, 6:48 a.m. UTC | #1
On 12/06/2024 23:58, Vladimir Zapolskiy wrote:
> Add sm8550 compatible consistent with CAMSS CCI interfaces, the list of
> clocks is reduced by removing "slow_ahb_src" clock, which is derived
> from "cpas_ahb" clock.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Bjorn Andersson June 26, 2024, 3:36 a.m. UTC | #2
On Thu, Jun 13, 2024 at 12:58:32AM GMT, Vladimir Zapolskiy wrote:
> Add sm8550 compatible consistent with CAMSS CCI interfaces, the list of
> clocks is reduced by removing "slow_ahb_src" clock, which is derived
> from "cpas_ahb" clock.
> 
> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

Andi, could you please take the two binding patches from this series
(patch 1 and 2) through your tree, so that I can take the dts changes
through the Qualcomm DeviceTree tree?

Regards,
Bjorn

> ---
>  .../devicetree/bindings/i2c/qcom,i2c-cci.yaml  | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index daf4e71b8e7f..e5c4b20446b6 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -31,6 +31,7 @@ properties:
>                - qcom,sm6350-cci
>                - qcom,sm8250-cci
>                - qcom,sm8450-cci
> +              - qcom,sm8550-cci
>            - const: qcom,msm8996-cci # CCI v2
>  
>    "#address-cells":
> @@ -195,6 +196,23 @@ allOf:
>              - const: cpas_ahb
>              - const: cci
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,sm8550-cci
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 3
> +          maxItems: 3
> +        clock-names:
> +          items:
> +            - const: camnoc_axi
> +            - const: cpas_ahb
> +            - const: cci
> +
>  additionalProperties: false
>  
>  examples:
> -- 
> 2.33.0
>
Wolfram Sang July 11, 2024, 9:38 a.m. UTC | #3
On Tue, Jun 25, 2024 at 10:36:43PM -0500, Bjorn Andersson wrote:
> On Thu, Jun 13, 2024 at 12:58:32AM GMT, Vladimir Zapolskiy wrote:
> > Add sm8550 compatible consistent with CAMSS CCI interfaces, the list of
> > clocks is reduced by removing "slow_ahb_src" clock, which is derived
> > from "cpas_ahb" clock.
> > 
> > Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> 
> Andi, could you please take the two binding patches from this series
> (patch 1 and 2) through your tree, so that I can take the dts changes
> through the Qualcomm DeviceTree tree?

Andi, ping for patches 1+2
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
index daf4e71b8e7f..e5c4b20446b6 100644
--- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
+++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
@@ -31,6 +31,7 @@  properties:
               - qcom,sm6350-cci
               - qcom,sm8250-cci
               - qcom,sm8450-cci
+              - qcom,sm8550-cci
           - const: qcom,msm8996-cci # CCI v2
 
   "#address-cells":
@@ -195,6 +196,23 @@  allOf:
             - const: cpas_ahb
             - const: cci
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,sm8550-cci
+    then:
+      properties:
+        clocks:
+          minItems: 3
+          maxItems: 3
+        clock-names:
+          items:
+            - const: camnoc_axi
+            - const: cpas_ahb
+            - const: cci
+
 additionalProperties: false
 
 examples: