From patchwork Thu Jun 13 17:05:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 13697171 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C819149E0A for ; Thu, 13 Jun 2024 17:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718298313; cv=none; b=X3viR59Jo4UwjfGvpHzPzN/mwZxHD/Y8CrH8PRC1kGICflJOveITYTHZNpW8DDSeeaH2pPiu2Ec7GyyWetWVgrtJGh1w31HZeQgSlCceBS4Nb7rTRDBw0SLF0J8N4c0kaTHMbZx2H/vyVeV3gKFMzxvh7ceJ0OYlfCnjITO39c4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718298313; c=relaxed/simple; bh=HIriNWIocgMjwNxbdTrc6hdy7i8ETZY5Lp1WWcPraew=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uG8uMnx5Y1M9swbuRz2l+csb0Q7JK44HleM60Xh/rW5b1WhTk7j6QAfUTKBNJ89pm+JnbKtnur3+L4+4guwbe03no9u5RcJgBuQDRuoG16g/JZQ/dpZnF+jmNhEySu4u6SvV4+TG86g90k1yZY32yTYWuuzYhorlIyhmAVS4/c4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=aSlngvGJ; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aSlngvGJ" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-52c8ddc2b29so1446211e87.3 for ; Thu, 13 Jun 2024 10:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718298309; x=1718903109; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5FbDBTh475IVXrIAo8lTadv4qb1jnkcH0RKtaD/LKVI=; b=aSlngvGJCasZ6DwHx8nP2maT0q/VdcuBAJ32/dZO3EGABttzm/nfIq2/yfLVViN34L 5fZk8vIpnnsjbzAtnAdcrmkdKMBR6NWmF/JXfWmJugp70T3mU+pq+zITRRy0R9UlRsx4 emgSiUY8kUe7bUeVe2ZOdvFI7MRRc85+mxmC3kJIVIsc21Y0rGsk5p0zn7JYbum+PleU FOCI4gh8Gs5nUgPiazRKOOh85Y+JllZY2Oq8MY6Q8sDZvR19X2svbk1M+c5FbJzjzNrO WAMnrMyA2ezFp1LX3LALnpv4c+CmarAMKrIwsrR2iEZsQpfJPEAWZsjvvC70xzMsYEMM T0ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718298309; x=1718903109; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5FbDBTh475IVXrIAo8lTadv4qb1jnkcH0RKtaD/LKVI=; b=DPl+Q1zfnE2D/rMk1pZNPakb7wrg4LUlb9VSO4Pboc+FePEHn5TMyPIrULhCI+jP30 9yvC63IlD+47i45thOB6QSQfYrSNuaF4A5/xiddKwii/y/SNgx6hHLFXaBonJunl9UhC vm0FF5KeHLCl5LfG6dznU22bMWzX5COaY+62H204VDpwpQBqfm7ITaF2CdZIiAtpkqCQ xzqgwOPNJCRrCE0AF+kbok0lLgzuWd7edaBS1WUO0RClGB/kN+qSaGZ0xzjZJA98f6TV Gl+eDnZZrM2Ojw9iNOU9vL9b0XsegJdUh8lBdqeP01hT+k2X0oWEHVjL3kUBVOtgDCRG mUiw== X-Gm-Message-State: AOJu0YxhWbMeLCLbbBEK8U7aMN2ft9SHkjBklv4X62A4b6XacSzbxRMA kKTv28Rj33SVToj3QaPneYVs8hxqBeksghbRoD3l9s8nEju/+cpsXa/DOi3bbBY= X-Google-Smtp-Source: AGHT+IGuznTjlxqgv3P0bkflpBLh9xuQS717dGNXxqv0wmC+Kmsqddvyv7lJuM6V8HQaJ/ykaiaJzw== X-Received: by 2002:a05:6512:41e:b0:52c:8abe:f54c with SMTP id 2adb3069b0e04-52ca6e6dc74mr285044e87.32.1718298309708; Thu, 13 Jun 2024 10:05:09 -0700 (PDT) Received: from umbar.lan ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52ca2825733sm287312e87.60.2024.06.13.10.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 10:05:09 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 13 Jun 2024 20:05:07 +0300 Subject: [PATCH v2 4/8] drm/msm/dpu: pull the is_cmd_mode out of _dpu_encoder_update_vsync_source() Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240613-dpu-handle-te-signal-v2-4-67a0116b5366@linaro.org> References: <20240613-dpu-handle-te-signal-v2-0-67a0116b5366@linaro.org> In-Reply-To: <20240613-dpu-handle-te-signal-v2-0-67a0116b5366@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1480; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=HIriNWIocgMjwNxbdTrc6hdy7i8ETZY5Lp1WWcPraew=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBmaybB5Z7y89l6cLJU2BChnXolSpVGWDwUrZSkL OaZ1V9hqdeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZmsmwQAKCRCLPIo+Aiko 1ULwB/9Pts9j6Uygy7d2/fSSfPP0RqwjRv5Iv9unMTzra3+hxJ9O0Kr//2C5aMkvHRJAxhDtDPI xoExO5kpEw1MspSzz9beEkuiO3KjLAtQ2AGEdpASLZldN+fGEsAmeC5uAcN4kAjKD05Vtt5pC40 KVEePDKceoilkivmi80GIUlqXY16PujTuS8xsFoSUPcCfSf43OQUwgcERq22JIJz5p1FwWsI1ch qyd7Iroz8L5T3ynIrCuTQ1GUwcLewRilsc9Ugby00p5QxnKsV8qa118qeVaWAbYjZj2oJjDj1lS GVi6+urbLyxS1sMgZdTudWDyCZ42ew965Rzbhey1d2CP3tIE X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Setting vsync source makes sense only for DSI CMD panels. Pull the is_cmd_mode condition out of the function into the calling code, so that it becomes more explicit. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 4988a1029431..bd37a56b4d03 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -736,8 +736,7 @@ static void _dpu_encoder_update_vsync_source(struct dpu_encoder_virt *dpu_enc, return; } - if (hw_mdptop->ops.setup_vsync_source && - disp_info->is_cmd_mode) { + if (hw_mdptop->ops.setup_vsync_source) { for (i = 0; i < dpu_enc->num_phys_encs; i++) vsync_cfg.ppnumber[i] = dpu_enc->hw_pp[i]->idx; @@ -1226,7 +1225,8 @@ static void _dpu_encoder_virt_enable_helper(struct drm_encoder *drm_enc) dpu_enc->cur_master->hw_mdptop->ops.intf_audio_select( dpu_enc->cur_master->hw_mdptop); - _dpu_encoder_update_vsync_source(dpu_enc, &dpu_enc->disp_info); + if (dpu_enc->disp_info.is_cmd_mode) + _dpu_encoder_update_vsync_source(dpu_enc, &dpu_enc->disp_info); if (dpu_enc->disp_info.intf_type == INTF_DSI && !WARN_ON(dpu_enc->num_phys_encs == 0)) {