| Message ID | 20240619061641.5261-3-quic_kbajaj@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | qdu1000: Fix LLCC reg property | expand |
On 6/19/24 08:16, Komal Bajaj wrote: > This reverts commit f0f99f371822c48847e02e56d6e7de507e18f186. > > QDU1000 has 7 register regions. The earlier commit 8e2506d01231 > ("dt-bindings: cache: qcom,llcc: Add LLCC compatible for QDU1000/QRU1000") > to add llcc compatible was reflecting the same, but dtsi change for > QDU1000 was not aligning with its binding. Later, commit f0f99f371822 > ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries") was merged > intended to fix this misalignment. > > After the LLCC driver refactor, each LLCC bank/channel need to be > represented as one register space to avoid mapping to the region where > access is not there. Hence, revert the commit f0f99f371822 ("dt-bindings: > cache: qcom,llcc: correct QDU1000 reg entries") to align QDU1000 llcc > binding with its dtsi node. > > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > --- For future reference, it would be good to have this as patch 1, to prevent the previous one introducing (fake) schema warnings Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
On Wed, Jun 19, 2024 at 11:46:41AM +0530, Komal Bajaj wrote: > This reverts commit f0f99f371822c48847e02e56d6e7de507e18f186. > > QDU1000 has 7 register regions. The earlier commit 8e2506d01231 > ("dt-bindings: cache: qcom,llcc: Add LLCC compatible for QDU1000/QRU1000") > to add llcc compatible was reflecting the same, but dtsi change for > QDU1000 was not aligning with its binding. Later, commit f0f99f371822 > ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries") was merged > intended to fix this misalignment. > > After the LLCC driver refactor, each LLCC bank/channel need to be > represented as one register space to avoid mapping to the region where > access is not there. Hence, revert the commit f0f99f371822 ("dt-bindings: > cache: qcom,llcc: correct QDU1000 reg entries") to align QDU1000 llcc > binding with its dtsi node. > > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> > --- > Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 2 +- I assume that Bjorn will apply this, I think I'm probably "meant" to apply patches for the cache bindings dir, but never added it to maintainers. I think Bjorn's been taking these via soc or w/e til now? > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml > index 192911696010..68ea5f70b75f 100644 > --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml > +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml > @@ -67,7 +67,6 @@ allOf: > compatible: > contains: > enum: > - - qcom,qdu1000-llcc > - qcom,sc7180-llcc > - qcom,sm6350-llcc > then: > @@ -132,6 +131,7 @@ allOf: > compatible: > contains: > enum: > + - qcom,qdu1000-llcc > - qcom,sc8180x-llcc > - qcom,sc8280xp-llcc > - qcom,x1e80100-llcc > -- > 2.42.0 >
diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml index 192911696010..68ea5f70b75f 100644 --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml @@ -67,7 +67,6 @@ allOf: compatible: contains: enum: - - qcom,qdu1000-llcc - qcom,sc7180-llcc - qcom,sm6350-llcc then: @@ -132,6 +131,7 @@ allOf: compatible: contains: enum: + - qcom,qdu1000-llcc - qcom,sc8180x-llcc - qcom,sc8280xp-llcc - qcom,x1e80100-llcc
This reverts commit f0f99f371822c48847e02e56d6e7de507e18f186. QDU1000 has 7 register regions. The earlier commit 8e2506d01231 ("dt-bindings: cache: qcom,llcc: Add LLCC compatible for QDU1000/QRU1000") to add llcc compatible was reflecting the same, but dtsi change for QDU1000 was not aligning with its binding. Later, commit f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries") was merged intended to fix this misalignment. After the LLCC driver refactor, each LLCC bank/channel need to be represented as one register space to avoid mapping to the region where access is not there. Hence, revert the commit f0f99f371822 ("dt-bindings: cache: qcom,llcc: correct QDU1000 reg entries") to align QDU1000 llcc binding with its dtsi node. Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> --- Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.42.0