| Message ID | 20240620081427.2860066-4-quic_varada@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable CPR for IPQ9574 | expand |
On Thu, Jun 20, 2024 at 01:44:23PM GMT, Varadarajan Narayanan wrote: > Add the APC power domain definitions used in IPQ9574. > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> The order of the S-o-B's is wrong. Who is the actual author of the patch? > --- > drivers/pmdomain/qcom/rpmpd.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >
On Thu, Jun 20, 2024 at 06:09:51PM +0300, Dmitry Baryshkov wrote: > On Thu, Jun 20, 2024 at 01:44:23PM GMT, Varadarajan Narayanan wrote: > > Add the APC power domain definitions used in IPQ9574. > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > The order of the S-o-B's is wrong. Who is the actual author of the > patch? Praveenkumar I <quic_ipkumar@quicinc.com> is the actual author. Thanks Varada
On Fri, Jun 21, 2024 at 01:00:31PM GMT, Varadarajan Narayanan wrote: > On Thu, Jun 20, 2024 at 06:09:51PM +0300, Dmitry Baryshkov wrote: > > On Thu, Jun 20, 2024 at 01:44:23PM GMT, Varadarajan Narayanan wrote: > > > Add the APC power domain definitions used in IPQ9574. > > > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > The order of the S-o-B's is wrong. Who is the actual author of the > > patch? > > Praveenkumar I <quic_ipkumar@quicinc.com> is the actual author. So the order of the tags in your patch is wrong.
On Fri, Jun 21, 2024 at 11:55:10PM +0300, Dmitry Baryshkov wrote: > On Fri, Jun 21, 2024 at 01:00:31PM GMT, Varadarajan Narayanan wrote: > > On Thu, Jun 20, 2024 at 06:09:51PM +0300, Dmitry Baryshkov wrote: > > > On Thu, Jun 20, 2024 at 01:44:23PM GMT, Varadarajan Narayanan wrote: > > > > Add the APC power domain definitions used in IPQ9574. > > > > > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > > > The order of the S-o-B's is wrong. Who is the actual author of the > > > patch? > > > > Praveenkumar I <quic_ipkumar@quicinc.com> is the actual author. > > So the order of the tags in your patch is wrong. Have fixed this and other comments and posted v2. Please review. Thanks Varada
diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c index 5e6280b4cf70..947d6a9c3897 100644 --- a/drivers/pmdomain/qcom/rpmpd.c +++ b/drivers/pmdomain/qcom/rpmpd.c @@ -38,6 +38,7 @@ static struct qcom_smd_rpm *rpmpd_smd_rpm; #define KEY_FLOOR_CORNER 0x636676 /* vfc */ #define KEY_FLOOR_LEVEL 0x6c6676 /* vfl */ #define KEY_LEVEL 0x6c766c76 /* vlvl */ +#define RPM_KEY_UV 0x00007675 /* "uv" */ #define MAX_CORNER_RPMPD_STATE 6 @@ -644,6 +645,23 @@ static const struct rpmpd_desc mdm9607_desc = { .max_state = RPM_SMD_LEVEL_TURBO, }; +static struct rpmpd apc_s1_lvl = { + .pd = { .name = "apc", }, + .res_type = RPMPD_SMPA, + .res_id = 1, + .key = RPM_KEY_UV, +}; + +static struct rpmpd *ipq9574_rpmpds[] = { + [IPQ9574_VDDAPC] = &apc_s1_lvl, +}; + +static const struct rpmpd_desc ipq9574_desc = { + .rpmpds = ipq9574_rpmpds, + .num_pds = ARRAY_SIZE(ipq9574_rpmpds), + .max_state = RPM_SMD_LEVEL_TURBO_HIGH, +}; + static struct rpmpd *msm8226_rpmpds[] = { [MSM8226_VDDCX] = &cx_s1a_corner, [MSM8226_VDDCX_AO] = &cx_s1a_corner_ao, @@ -931,6 +949,7 @@ static const struct rpmpd_desc qcm2290_desc = { }; static const struct of_device_id rpmpd_match_table[] = { + { .compatible = "qcom,ipq9574-rpmpd", .data = &ipq9574_desc }, { .compatible = "qcom,mdm9607-rpmpd", .data = &mdm9607_desc }, { .compatible = "qcom,msm8226-rpmpd", .data = &msm8226_desc }, { .compatible = "qcom,msm8909-rpmpd", .data = &msm8916_desc },