diff mbox series

[v2,1/3] dt-bindings: arm: qcom: add sa8775p-ride Rev 3

Message ID 20240625151430.34024-2-brgl@bgdev.pl (mailing list archive)
State Superseded
Headers show
Series arm64: dts: qcom: sa8775p-ride: support both board variants | expand

Commit Message

Bartosz Golaszewski June 25, 2024, 3:14 p.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Document the compatible for revision 3 of the sa8775p-ride board.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski June 26, 2024, 8:59 a.m. UTC | #1 
On 25/06/2024 17:14, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Document the compatible for revision 3 of the sa8775p-ride board.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index ec1c10a12470..000037f4a712 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -895,6 +895,7 @@ properties:
>        - items:
>            - enum:
>                - qcom,sa8775p-ride
> +              - qcom,sa8775p-ride-r3

The board is not compatible with earlier revision?

Best regards,
Krzysztof
Bartosz Golaszewski June 26, 2024, 11:02 a.m. UTC | #2 
On Wed, Jun 26, 2024 at 11:00 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 25/06/2024 17:14, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Document the compatible for revision 3 of the sa8775p-ride board.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index ec1c10a12470..000037f4a712 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -895,6 +895,7 @@ properties:
> >        - items:
> >            - enum:
> >                - qcom,sa8775p-ride
> > +              - qcom,sa8775p-ride-r3
>
> The board is not compatible with earlier revision?
>

In what way? Can you run the same DTB on both? Sure. Will ethernet
work in both cases? No.

Bart
Krzysztof Kozlowski June 26, 2024, 11:03 a.m. UTC | #3 
On 26/06/2024 13:02, Bartosz Golaszewski wrote:
> On Wed, Jun 26, 2024 at 11:00 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 25/06/2024 17:14, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>>
>>> Document the compatible for revision 3 of the sa8775p-ride board.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>>> ---
>>>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> index ec1c10a12470..000037f4a712 100644
>>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>>> @@ -895,6 +895,7 @@ properties:
>>>        - items:
>>>            - enum:
>>>                - qcom,sa8775p-ride
>>> +              - qcom,sa8775p-ride-r3
>>
>> The board is not compatible with earlier revision?
>>
> 
> In what way? Can you run the same DTB on both? Sure. Will ethernet
> work in both cases? No.

OK

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index ec1c10a12470..000037f4a712 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -895,6 +895,7 @@  properties:
       - items:
           - enum:
               - qcom,sa8775p-ride
+              - qcom,sa8775p-ride-r3
           - const: qcom,sa8775p
 
       - items: