diff mbox series

[1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers

Message ID 20240627122015.30945-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State Accepted
Headers show
Series [1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers | expand

Commit Message

Krzysztof Kozlowski June 27, 2024, 12:20 p.m. UTC
Add appropriate mappings of Soundwire ports of WSA8845 speaker.  This
solves second (south) speaker sound distortions when playing audio.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Bindings:
https://lore.kernel.org/all/20240626-port-map-v1-3-bd8987d2b332@linaro.org/

Can be applied independently, if bindings are fine.
---
 arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 2 ++
 1 file changed, 2 insertions(+)

Comments

Neil Armstrong June 27, 2024, 12:33 p.m. UTC | #1
On 27/06/2024 14:20, Krzysztof Kozlowski wrote:
> Add appropriate mappings of Soundwire ports of WSA8845 speaker.  This
> solves second (south) speaker sound distortions when playing audio.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Bindings:
> https://lore.kernel.org/all/20240626-port-map-v1-3-bd8987d2b332@linaro.org/
> 
> Can be applied independently, if bindings are fine.
> ---
>   arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> index e0dc03a97771..2e12219006c9 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> @@ -1106,6 +1106,7 @@ north_spkr: speaker@0,0 {
>   
>   		#sound-dai-cells = <0>;
>   		sound-name-prefix = "SpkrLeft";
> +		qcom,port-mapping = <1 2 3 7 10 13>;
>   	};
>   
>   	/* WSA8845, Speaker South */
> @@ -1123,6 +1124,7 @@ south_spkr: speaker@0,1 {
>   
>   		#sound-dai-cells = <0>;
>   		sound-name-prefix = "SpkrRight";
> +		qcom,port-mapping = <4 5 6 7 11 13>;
>   	};
>   };
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Bjorn Andersson July 3, 2024, 3:37 a.m. UTC | #2
On Thu, 27 Jun 2024 14:20:13 +0200, Krzysztof Kozlowski wrote:
> Add appropriate mappings of Soundwire ports of WSA8845 speaker.  This
> solves second (south) speaker sound distortions when playing audio.
> 
> 

Applied, thanks!

[1/3] arm64: dts: qcom: sm8550-hdk: add port mapping to speakers
      commit: 21663c69b3f75ae52d9f1f6b844aa2bb314a6a3f
[2/3] arm64: dts: qcom: sm8550-mtp: add port mapping to speakers
      commit: 5ba3ba4d4439709c68b96aef3b0e71c63fd9d665
[3/3] arm64: dts: qcom: sm8550-qrd: add port mapping to speakers
      commit: 6bf99fdb4c93b165e77b879606f2e9c2571399da

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
index e0dc03a97771..2e12219006c9 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
@@ -1106,6 +1106,7 @@  north_spkr: speaker@0,0 {
 
 		#sound-dai-cells = <0>;
 		sound-name-prefix = "SpkrLeft";
+		qcom,port-mapping = <1 2 3 7 10 13>;
 	};
 
 	/* WSA8845, Speaker South */
@@ -1123,6 +1124,7 @@  south_spkr: speaker@0,1 {
 
 		#sound-dai-cells = <0>;
 		sound-name-prefix = "SpkrRight";
+		qcom,port-mapping = <4 5 6 7 11 13>;
 	};
 };