| Message ID | 20240703122340.26864-2-quic_jinlmao@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | coresight: core: Add device name support | expand |
On 03/07/2024 14:23, Mao Jinlong wrote: > Current name of coresight component's folder consists of prefix of > the device and the id in the device list. When run 'ls' command, > we can get the register address of the device. Take CTI for example, > if we want to set the config for modem CTI, but we can't know which > CTI is modem CTI from all current information. > > cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0 > cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1 > > Add device-name in device tree which can provide a better description > of the coresight device. It can provide the info like the system or > HW it belongs to. > > Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> > --- > .../devicetree/bindings/arm/arm,coresight-cti.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++ > .../devicetree/bindings/arm/arm,coresight-stm.yaml | 6 ++++++ > .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 6 ++++++ > 4 files changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml > index 2d5545a2b49c..6a73eaa66a42 100644 > --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml > @@ -98,6 +98,12 @@ properties: > power-domains: > maxItems: 1 > > + arm,cs-dev-name: > + $ref: /schemas/types.yaml#/definitions/string > + description: > + Define the name which can describe what kind of HW or system the > + coresight device belongs to. Don't we use already label for such cases? Power domains, input, leds, panels, IIO, hwmon and more. Best regards, Krzysztof
On 24/07/2024 20:13, Krzysztof Kozlowski wrote: > On 03/07/2024 14:23, Mao Jinlong wrote: >> Current name of coresight component's folder consists of prefix of >> the device and the id in the device list. When run 'ls' command, >> we can get the register address of the device. Take CTI for example, >> if we want to set the config for modem CTI, but we can't know which >> CTI is modem CTI from all current information. >> >> cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0 >> cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1 >> >> Add device-name in device tree which can provide a better description >> of the coresight device. It can provide the info like the system or >> HW it belongs to. >> >> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> >> --- >> .../devicetree/bindings/arm/arm,coresight-cti.yaml | 6 ++++++ >> .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++ >> .../devicetree/bindings/arm/arm,coresight-stm.yaml | 6 ++++++ >> .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 6 ++++++ >> 4 files changed, 24 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml >> index 2d5545a2b49c..6a73eaa66a42 100644 >> --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml >> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml >> @@ -98,6 +98,12 @@ properties: >> power-domains: >> maxItems: 1 >> >> + arm,cs-dev-name: >> + $ref: /schemas/types.yaml#/definitions/string >> + description: >> + Define the name which can describe what kind of HW or system the >> + coresight device belongs to. > > Don't we use already label for such cases? Power domains, input, leds, > panels, IIO, hwmon and more. We do and if we can get hold of them, that would be ideal. but do we get them in the binary DT blob ? At least I couldn't see them on my Juno dtb. Cheers Suzuki > > Best regards, > Krzysztof >
On 18/10/2024 12:17, Suzuki K Poulose wrote: > On 24/07/2024 20:13, Krzysztof Kozlowski wrote: >> On 03/07/2024 14:23, Mao Jinlong wrote: >>> Current name of coresight component's folder consists of prefix of >>> the device and the id in the device list. When run 'ls' command, >>> we can get the register address of the device. Take CTI for example, >>> if we want to set the config for modem CTI, but we can't know which >>> CTI is modem CTI from all current information. >>> >>> cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0 >>> cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1 >>> >>> Add device-name in device tree which can provide a better description >>> of the coresight device. It can provide the info like the system or >>> HW it belongs to. >>> >>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> >>> --- >>> .../devicetree/bindings/arm/arm,coresight-cti.yaml | 6 ++++++ >>> .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++ >>> .../devicetree/bindings/arm/arm,coresight-stm.yaml | 6 ++++++ >>> .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 6 ++++++ >>> 4 files changed, 24 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml >>> index 2d5545a2b49c..6a73eaa66a42 100644 >>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml >>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml >>> @@ -98,6 +98,12 @@ properties: >>> power-domains: >>> maxItems: 1 >>> >>> + arm,cs-dev-name: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + description: >>> + Define the name which can describe what kind of HW or system the >>> + coresight device belongs to. >> >> Don't we use already label for such cases? Power domains, input, leds, >> panels, IIO, hwmon and more. > > We do and if we can get hold of them, that would be ideal. but do we get > them in the binary DT blob ? At least I couldn't see them on my Juno > dtb. I meant "label" property (a string). See above bindings. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml index 2d5545a2b49c..6a73eaa66a42 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml @@ -98,6 +98,12 @@ properties: power-domains: maxItems: 1 + arm,cs-dev-name: + $ref: /schemas/types.yaml#/definitions/string + description: + Define the name which can describe what kind of HW or system the + coresight device belongs to. + arm,cti-ctm-id: $ref: /schemas/types.yaml#/definitions/uint32 description: diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml index 6745b4cc8f1c..578c5e3227a6 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml @@ -38,6 +38,12 @@ properties: enum: - arm,coresight-dummy-source + arm,cs-dev-name: + $ref: /schemas/types.yaml#/definitions/string + description: + Define the name which can describe what kind of HW or system the + coresight device belongs to. + out-ports: $ref: /schemas/graph.yaml#/properties/ports diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml index 378380c3f5aa..3261d4f4adbb 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml @@ -51,6 +51,12 @@ properties: - const: stm-base - const: stm-stimulus-base + arm,cs-dev-name: + $ref: /schemas/types.yaml#/definitions/string + description: + Define the name which can describe what kind of HW or system the + coresight device belongs to. + clocks: minItems: 1 maxItems: 2 diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml index 8eec07d9d454..12bb6403e934 100644 --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml @@ -44,6 +44,12 @@ properties: minItems: 1 maxItems: 2 + arm,cs-dev-name: + $ref: /schemas/types.yaml#/definitions/string + description: + Define the name which can describe what kind of HW or system the + coresight device belongs to. + qcom,dsb-element-bits: description: Specifies the DSB(Discrete Single Bit) element size supported by
Current name of coresight component's folder consists of prefix of the device and the id in the device list. When run 'ls' command, we can get the register address of the device. Take CTI for example, if we want to set the config for modem CTI, but we can't know which CTI is modem CTI from all current information. cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0 cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1 Add device-name in device tree which can provide a better description of the coresight device. It can provide the info like the system or HW it belongs to. Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> --- .../devicetree/bindings/arm/arm,coresight-cti.yaml | 6 ++++++ .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++ .../devicetree/bindings/arm/arm,coresight-stm.yaml | 6 ++++++ .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 6 ++++++ 4 files changed, 24 insertions(+)