| Message ID | 20240703221248.3640490-1-quic_collinsd@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | spmi: pmic-arb: add missing newline in dev_err format strings | expand |
On Wed, Jul 03, 2024 at 03:12:48PM GMT, David Collins wrote: > dev_err() format strings should end with '\n'. Several such > format strings in the spmi-pmic-arb driver are missing it. > Add newlines where needed. > > Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead of arbiter") > Signed-off-by: David Collins <quic_collinsd@quicinc.com> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Regards, Bjorn > --- > drivers/spmi/spmi-pmic-arb.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c > index 791cdc160c51..c408ded0c00f 100644 > --- a/drivers/spmi/spmi-pmic-arb.c > +++ b/drivers/spmi/spmi-pmic-arb.c > @@ -398,7 +398,7 @@ static int pmic_arb_fmt_read_cmd(struct spmi_pmic_arb_bus *bus, u8 opc, u8 sid, > > *offset = rc; > if (bc >= PMIC_ARB_MAX_TRANS_BYTES) { > - dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested", > + dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n", > PMIC_ARB_MAX_TRANS_BYTES, len); > return -EINVAL; > } > @@ -477,7 +477,7 @@ static int pmic_arb_fmt_write_cmd(struct spmi_pmic_arb_bus *bus, u8 opc, > > *offset = rc; > if (bc >= PMIC_ARB_MAX_TRANS_BYTES) { > - dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested", > + dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n", > PMIC_ARB_MAX_TRANS_BYTES, len); > return -EINVAL; > } > @@ -1702,7 +1702,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev, > > index = of_property_match_string(node, "reg-names", "cnfg"); > if (index < 0) { > - dev_err(dev, "cnfg reg region missing"); > + dev_err(dev, "cnfg reg region missing\n"); > return -EINVAL; > } > > @@ -1712,7 +1712,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev, > > index = of_property_match_string(node, "reg-names", "intr"); > if (index < 0) { > - dev_err(dev, "intr reg region missing"); > + dev_err(dev, "intr reg region missing\n"); > return -EINVAL; > } > > -- > 2.25.1 > >
Quoting David Collins (2024-07-03 15:12:48) > dev_err() format strings should end with '\n'. Several such > format strings in the spmi-pmic-arb driver are missing it. > Add newlines where needed. > > Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead of arbiter") > Signed-off-by: David Collins <quic_collinsd@quicinc.com> > --- Applied to spmi-next
diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 791cdc160c51..c408ded0c00f 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -398,7 +398,7 @@ static int pmic_arb_fmt_read_cmd(struct spmi_pmic_arb_bus *bus, u8 opc, u8 sid, *offset = rc; if (bc >= PMIC_ARB_MAX_TRANS_BYTES) { - dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested", + dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n", PMIC_ARB_MAX_TRANS_BYTES, len); return -EINVAL; } @@ -477,7 +477,7 @@ static int pmic_arb_fmt_write_cmd(struct spmi_pmic_arb_bus *bus, u8 opc, *offset = rc; if (bc >= PMIC_ARB_MAX_TRANS_BYTES) { - dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested", + dev_err(&bus->spmic->dev, "pmic-arb supports 1..%d bytes per trans, but:%zu requested\n", PMIC_ARB_MAX_TRANS_BYTES, len); return -EINVAL; } @@ -1702,7 +1702,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev, index = of_property_match_string(node, "reg-names", "cnfg"); if (index < 0) { - dev_err(dev, "cnfg reg region missing"); + dev_err(dev, "cnfg reg region missing\n"); return -EINVAL; } @@ -1712,7 +1712,7 @@ static int spmi_pmic_arb_bus_init(struct platform_device *pdev, index = of_property_match_string(node, "reg-names", "intr"); if (index < 0) { - dev_err(dev, "intr reg region missing"); + dev_err(dev, "intr reg region missing\n"); return -EINVAL; }
dev_err() format strings should end with '\n'. Several such format strings in the spmi-pmic-arb driver are missing it. Add newlines where needed. Fixes: 02922ccbb330 ("spmi: pmic-arb: Register controller for bus instead of arbiter") Signed-off-by: David Collins <quic_collinsd@quicinc.com> --- drivers/spmi/spmi-pmic-arb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)